Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and improve introduction in zha.markdown #28869

Open
wants to merge 11 commits into
base: current
Choose a base branch
from

Conversation

Hedda
Copy link
Contributor

@Hedda Hedda commented Sep 11, 2023

Proposed change

Updated and improved the ZHA integration introduction section (including adding a couple of links to other sections in this ZHA documentation that IMHO isalso very important for beginners to read and be aware of).

Since the ZHA integration userbase/usage increased (possibly due to SkyConnect/Yellow + other factors) we see more and more new users of the ZHA integration now posting in Home Assistant's community forum every day asking for help soon after they run into common setup or environment issues when getting started with the ZHA integration and Zigbee.

I think most of those issues occur because many of those new users did not understand the basic Zigbee fundamentals and limitations that for for better or worse users should really need to know before the begin creating a new Zigbee network and start simply adding any Zigbee devices located anywhere in their home to the ZHA integration.

I believe this improved introduction could help many new users avoid most of those basic issues or common pitfalls for Zigbee, and hopefully, they will get a better out-of-the-box user experience from the very beginning and not early in their Zigbee adoption have to go into delving deeper into Zigbee troubleshooting to correct simple setup mistakes that are caused by common Zigbee limitations.

For example; new users are not aware that they must add many Zigbee Router devices to get any kind of decent range and coverage, epecially before they start adding Zigbee End Devices.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Improve ZHA introduction in zha.markdown
@home-assistant home-assistant bot added the current This PR goes into the current branch label Sep 11, 2023
Incorrect usage of the terminology term: “backwards compatible”, use “backward compatible” instead.
Copy link
Contributor

@puddly puddly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you make the changes a bit more compact? There are many phrases that incorporate too much jargon and can often times be entirely removed without changing any meaning:

  • "Zigbee Coordinator radio adapter or hardware module"
  • "physical radio adapter"
  • "from an end-user's point-of-view"

Specification revisions and acronyms are a little too techincal for an introduction so let's keep it as simple as possible.

source/_integrations/zha.markdown Outdated Show resolved Hide resolved
source/_integrations/zha.markdown Outdated Show resolved Hide resolved
source/_integrations/zha.markdown Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 13, 2023 11:59
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Rewrote to remove some jargon
@Hedda
Copy link
Contributor Author

Hedda commented Sep 13, 2023

Could you make the changes a bit more compact? There are many phrases that incorporate too much jargon and can often times be entirely removed without changing any meaning:

  • "Zigbee Coordinator radio adapter or hardware module"
  • "physical radio adapter"
  • "from an end-user's point-of-view"

Specification revisions and acronyms are a little too techincal for an introduction so let's keep it as simple as possible.

@puddly Tried to get it more compact, by at least removing most technical jargon + acronyms, and splitting only sections.

@Hedda Hedda requested a review from puddly September 24, 2023 18:11
@Hedda Hedda marked this pull request as ready for review September 28, 2023 10:26
@Hedda
Copy link
Contributor Author

Hedda commented Nov 24, 2023

@puddly I have tried to make all requested changes so wondering if there is any chance to get this reviewed again?

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 7bd8fde
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6630c3816a4398000876ab09
😎 Deploy Preview https://deploy-preview-28869--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@puddly puddly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that this documentation is for the ZHA integration, not for Zigbee in general!

Let's focus on paring down the documentation. Right now, it's so long and dense that a typical user of Home Assistant can't just open it up and look at it without being overwhelmed. We don't need to cover every use case and every possible question someone can possibly have about Zigbee in the documentation.

Right now, we don't have a place for in-depth Zigbee documentation like this. Perhaps you can instead extend the Zigpy wiki and we then migrate the content in the future to a generated documentation website?

source/_integrations/zha.markdown Outdated Show resolved Hide resolved
source/_integrations/zha.markdown Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft March 20, 2024 19:30
Update introduction based on feedback.
@Hedda
Copy link
Contributor Author

Hedda commented Mar 25, 2024

Keep in mind that this documentation is for the ZHA integration, not for Zigbee in general!

Let's focus on paring down the documentation.

OK, I now tried restructuring and rewritten the introduction section based on that feedback while keeping "must have" info.

@Hedda Hedda marked this pull request as ready for review March 25, 2024 08:10
@home-assistant home-assistant bot requested a review from puddly March 25, 2024 08:10
@Hedda Hedda marked this pull request as draft March 25, 2024 08:15
@Hedda Hedda marked this pull request as ready for review March 25, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants