Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "Zigbee Groups" in ZHA integration #29316

Open
wants to merge 10 commits into
base: current
Choose a base branch
from

Conversation

Hedda
Copy link
Contributor

@Hedda Hedda commented Oct 12, 2023

Proposed change

Add initial documentation for "Zigbee Groups" in the ZHA integration (which was missing documentation about "Zigbee Group").

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
  • The documentation follows the Home Assistant documentation standards.

Add initial documentation for "Zigbee Groups" in the ZHA integration.
@home-assistant home-assistant bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 12, 2023
Heading levels should increment by one level at a time heading-increment remark-lint
Copy link
Contributor

@j4n-e4t j4n-e4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to expand the docs on the new Zigbee Groups feature. However, I would change the phrasing a bit 😉

source/_integrations/zha.markdown Outdated Show resolved Hide resolved
source/_integrations/zha.markdown Outdated Show resolved Hide resolved
Hedda and others added 2 commits November 7, 2023 11:52
Co-authored-by: j4n-e4t <130256240+j4n-e4t@users.noreply.github.com>
Co-authored-by: j4n-e4t <130256240+j4n-e4t@users.noreply.github.com>
@Hedda
Copy link
Contributor Author

Hedda commented Nov 7, 2023

Great idea to expand the docs on the new Zigbee Groups feature. However, I would change the phrasing a bit

@j4n-e4t Thanks! I have commited your suggested changes now.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 877b24d
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6630c3a16a4398000876ab18
😎 Deploy Preview https://deploy-preview-29316--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@puddly puddly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #28869

Let's keep this documentation specific to ZHA, so there's no need to explain what Zigbee groups are, how they're used, and so on. Just show/explain how to bind and unbind devices/groups.

@home-assistant home-assistant bot marked this pull request as draft March 20, 2024 19:39
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Hedda
Copy link
Contributor Author

Hedda commented Mar 25, 2024

Let's keep this documentation specific to ZHA, so there's no need to explain what Zigbee groups are, how they're used, and so on. Just show/explain how to bind and unbind devices/groups.

@puddly is this not better a start than not having any section about this? This is at least a beginning that others could build on.

@Hedda Hedda marked this pull request as ready for review March 25, 2024 09:33
@home-assistant home-assistant bot requested review from j4n-e4t and puddly March 25, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants