Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Prusa MK2.5/MK3 as supported #32031

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

the-ress
Copy link
Contributor

@the-ress the-ress commented Mar 25, 2024

Proposed change

Documents added support for Prusa MK3 and MK2.5 printers in the existing PrusaLink integration.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@the-ress the-ress requested a review from balloob as a code owner March 25, 2024 23:58
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Mar 25, 2024
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit da4fd35
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6603fd158e43a30009f0d7b5
😎 Deploy Preview https://deploy-preview-32031--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


To obtain the hostname, username, and password:
To obtain the hostname, username, and password on Prusa MINI/MINI+/MK3.9/MK4/XL:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you document on how to obtain the API token on MK2.5/3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't document it because there's no good way to retrieve the credentials from MK2.5/MK3. (You enter the credentials when you first set up PrusaLink, after that you have to remember them or use a password manager etc.)

I'll try to mention this in the docs somehow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c0ffeeca7
c0ffeeca7 previously approved these changes Mar 27, 2024
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @the-ress 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Mar 27, 2024
@edenhaus edenhaus enabled auto-merge (squash) March 27, 2024 14:27
@edenhaus edenhaus disabled auto-merge March 27, 2024 14:27
@edenhaus edenhaus added awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Mar 27, 2024
@c0ffeeca7 c0ffeeca7 merged commit 1913940 into home-assistant:next Mar 27, 2024
6 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Mar 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants