Add support for arcam fmj receivers #24621

elupus · 2019-06-19T17:08:27Z

Description:

Add support for arcam fmj receivers

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9660

Example entry for `configuration.yaml` (if applicable):

arcam_fmj:
  - host: 192.168.0.20
    zone:
      1:
        turn_on:
          service: 'broadlink.send'
          data:
            host: 192.168.0.21
            packet: JgAVADodHTo6HR0dHR0dOh0dHR06Oh0dHQ0FAA==
      2:

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

frenck · 2019-06-19T19:17:11Z

.coveragerc

@@ -38,6 +38,7 @@ omit =
    homeassistant/components/apple_tv/*
    homeassistant/components/aqualogic/*
    homeassistant/components/aquostv/media_player.py
+    homeassistant/components/arcam_fmj/*


Make sure you don't exclude the tests for your config flow...

As noted below, there is not real config flow. Only import. Since device registry is non working anyway for this integration (can't get unique id) i could just drop it and move back to old way?

We should still test the config flow. That module needs 100% coverage.

frenck · 2019-06-19T19:18:48Z

homeassistant/components/arcam_fmj/config_flow.py

+        """Initialize the config flow."""
+        self._config = OrderedDict()
+
+    async def async_step_import(self, import_config):


So why only the import? That seems a bit inconvenient for the user?

Because without configuring a turn_on service call with an IR blaster or similar it's quite limited in use. And there is no good way to do that from config flows at the moment. Perhaps once option flows are in place...

homeassistant/components/arcam_fmj/__init__.py

homeassistant/components/arcam_fmj/const.py

homeassistant/components/arcam_fmj/media_player.py

Otherwise they won't be called in loop

elupus · 2019-06-20T12:09:51Z

Currently tests are failing since lib is 3.6 only. depends on yields in async functions. I will see if can fix that, but i oh so wish we could speed up the 3.5 removal :)

edit: No long the case

homeassistant/components/arcam_fmj/media_player.py

elupus · 2019-07-07T11:23:48Z

Anything more i need to look at before I press the merge button on this?

MartinHjelmare · 2019-07-07T12:31:49Z

Please don't merge until another member has approved.

MartinHjelmare

Looks good!

… into hive_water_heater * 'hive_water_heater' of github.com:Rendili/home-assistant: (21 commits) Sensibo, add HVAC_MODE_OFF (home-assistant#25016) Add support for arcam fmj receivers (home-assistant#24621) Enphase envoy individual inverter production (home-assistant#24445) Implement Twilio SMS notify MediaUrl support (home-assistant#24971) Climate 1.0 (home-assistant#23899) Correct socket use in cert_expiry platform (home-assistant#25011) Added missing yeelight models mapping (home-assistant#24963) Install requirements for integrations in packages before importing them. (home-assistant#25005) Upgrade insteonplm to 0.16.0 and add INSTEON scene triggering (home-assistant#24765) Upgrade hdate==0.8.8 (home-assistant#25008) upgrade switchmate to latest lib (home-assistant#25006) Test dependency updates (home-assistant#25004) Add support for aurora ABB Powerone solar photovoltaic inverter (home-assistant#24809) Sleepiq single sleeper crash (home-assistant#24941) Changes as per code review of home-assistant#24646 (home-assistant#24917) Upgrade mypy to 0.711, drop no longer needed workarounds (home-assistant#24998) Adds Stale Probot for issues (home-assistant#24985) Adds Lock Threads Probot (home-assistant#24984) Switched from tuyapy to tuyaha as 1st one is not maintained (home-assistant#24821) Fix errors if rest source becomes unavailable (home-assistant#24986) ... # Conflicts: # homeassistant/components/hive/__init__.py # homeassistant/components/hive/climate.py

@callback

* Add arcam_fmj support * Just use use state in player avoid direct client access * Avoid leaking exceptions on invalid data * Fix return value for volume in case of 0 * Mark component as having no coverage * Add new requirement * Add myself as maintainer * Correct linting errors * Use async_create_task instead of async_add_job * Use new style string format instead of concat * Don't call init of base class without init * Annotate callbacks with @callback Otherwise they won't be called in loop * Reduce log level to debug * Use async_timeout instead of wait_for * Bump to version of arcam_fmj supporting 3.5 * Fix extra spaces * Drop somewhat flaky unique_id * Un-blackify ident to satisy pylint * Un-blackify ident to satisy pylint * Move default name calculation to config validation * Add test folder * Drop unused code * Add tests for config flow import

homeassistant added cla-signed new-integration integration: arcam_fmj labels Jun 19, 2019

elupus mentioned this pull request Jun 19, 2019

Add arcam_fmj media player home-assistant/home-assistant.io#9660

Merged

2 tasks

elupus added 7 commits June 19, 2019 19:17

Add arcam_fmj support

0ec5b8a

Just use use state in player avoid direct client access

2bbc589

Avoid leaking exceptions on invalid data

44ae043

Fix return value for volume in case of 0

b80b02b

Mark component as having no coverage

6c0bf4c

Add new requirement

e582e17

Add myself as maintainer

349f721

elupus force-pushed the arcam_fmj branch from 31786e4 to 349f721 Compare June 19, 2019 17:18

Correct linting errors

68ed46c

frenck reviewed Jun 19, 2019

View reviewed changes

MartinHjelmare reviewed Jun 20, 2019

View reviewed changes

elupus added 6 commits June 20, 2019 13:15

Use async_create_task instead of async_add_job

659d481

Use new style string format instead of concat

d8d5049

Don't call init of base class without init

70e6940

Annotate callbacks with @callback

0d16fed

Otherwise they won't be called in loop

Reduce log level to debug

3ecd2e5

Use async_timeout instead of wait_for

efbb024

MartinHjelmare reviewed Jun 30, 2019

View reviewed changes

homeassistant/components/arcam_fmj/media_player.py Outdated Show resolved Hide resolved

elupus added 5 commits July 2, 2019 00:44

Bump to version of arcam_fmj supporting 3.5

1ee6d1c

Fix extra spaces

68de03e

Drop somewhat flaky unique_id

e0d3745

Un-blackify ident to satisy pylint

a7a0d68

Un-blackify ident to satisy pylint

a996589

elupus added 4 commits July 7, 2019 18:10

Move default name calculation to config validation

8b2ac93

Add test folder

51834ea

Drop unused code

8aa1743

Add tests for config flow import

10fd948

MartinHjelmare approved these changes Jul 8, 2019

View reviewed changes

MartinHjelmare merged commit ab832cd into home-assistant:dev Jul 8, 2019

balloob mentioned this pull request Jul 17, 2019

0.96.0 #25205

Merged

elupus deleted the arcam_fmj branch January 2, 2020 23:11

elupus mentioned this pull request May 15, 2020

Support config entry unload in arcam_fmj #35656

Merged

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for arcam fmj receivers #24621

Add support for arcam fmj receivers #24621

elupus commented Jun 19, 2019 •

edited

frenck Jun 19, 2019

elupus Jul 7, 2019

MartinHjelmare Jul 7, 2019

frenck Jun 19, 2019

elupus Jun 20, 2019

elupus commented Jun 20, 2019 •

edited

elupus commented Jul 7, 2019

MartinHjelmare commented Jul 7, 2019

MartinHjelmare left a comment

Add support for arcam fmj receivers #24621

Add support for arcam fmj receivers #24621

Conversation

elupus commented Jun 19, 2019 • edited

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

frenck Jun 19, 2019

Choose a reason for hiding this comment

elupus Jul 7, 2019

Choose a reason for hiding this comment

MartinHjelmare Jul 7, 2019

Choose a reason for hiding this comment

frenck Jun 19, 2019

Choose a reason for hiding this comment

elupus Jun 20, 2019

Choose a reason for hiding this comment

elupus commented Jun 20, 2019 • edited

elupus commented Jul 7, 2019

MartinHjelmare commented Jul 7, 2019

MartinHjelmare left a comment

Choose a reason for hiding this comment

elupus commented Jun 19, 2019 •

edited

Example entry for `configuration.yaml` (if applicable):

elupus commented Jun 20, 2019 •

edited