Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch actions are now blocking #2785

Closed
TomBrien opened this issue May 22, 2024 · 7 comments · Fixed by #2787
Closed

Watch actions are now blocking #2785

TomBrien opened this issue May 22, 2024 · 7 comments · Fixed by #2787
Assignees

Comments

@TomBrien
Copy link
Member

TomBrien commented May 22, 2024

iOS device model, version and app version

Model Name: iPhone 14 pro / series 8
Software Version: iOS 17.5 / watchOS 10.5
App version:

Home Assistant Core Version

Describe the bug

Watch actions used to be queue able, i.e. tapping multiple actions would fire them all in order without having to wait for each one to be confirmed. This was great if you wanted to quickly carry out a number of tasks (for example when walking into a room, turn the lights on, close the blinds and turn the TV on). Now when actions are fired the UI blocks other actions from being selected until the first has completed meaning what used to take a couple of seconds now takes tens of seconds or longer.

To Reproduce

Expected behavior

It'd be nice to be able to "queue up" actions again, not have to wait for each to be acknowledged.

Screenshots

Additional context

@bgoncal
Copy link
Member

bgoncal commented May 22, 2024

Good point, I will change it back to the old way

@bgoncal bgoncal self-assigned this May 22, 2024
@TomBrien
Copy link
Member Author

Thanks Bruno. I wondered if the blocking behaviour could be limited to each action's button. I.e. a spinner on the right and block that button, avoiding accidental double taps would be awesome.

@bgoncal
Copy link
Member

bgoncal commented May 22, 2024

Thanks Bruno. I wondered if the blocking behaviour could be limited to each action's button. I.e. a spinner on the right and block that button, avoiding accidental double taps would be awesome.

Thats what I also had in mind 🤘🏻

@bgoncal
Copy link
Member

bgoncal commented May 23, 2024

@TomBrien I used the spinner replacing the action icon, but the rest is the same, chekc the PR video and let me know what you think

@TomBrien
Copy link
Member Author

That looks brilliant. I'll test it when that merges and let you know. Thanks Bruno

@TomBrien
Copy link
Member Author

@bgoncal Just tried the new build, seems perfect! Thanks again

@bgoncal
Copy link
Member

bgoncal commented May 24, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants