Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ffmpeg.rb #109

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Update ffmpeg.rb #109

merged 1 commit into from
Jun 23, 2022

Conversation

Wicky2k8
Copy link
Contributor

@slhck
Copy link
Contributor

slhck commented Jun 23, 2022

This only works when the non-default formula is installed, right? What happens when the user doesn't have that?

@Wicky2k8
Copy link
Contributor Author

It won't work, but that's noted in the information on the main screen ("The ZVBI library has to be installed before running the FFmpeg formula.")

Anyways that issue already exists with the current setup, this just allows it to find zvbi if it is installed and the option is chosen (currently that fails)

@slhck
Copy link
Contributor

slhck commented Jun 23, 2022

In that case it would make sense to directly link to the other tap in the README, so that users will know from where they have to install the library.

Anyway, this makes sense, merging for now. Thanks!

@slhck slhck merged commit 96c7947 into homebrew-ffmpeg:master Jun 23, 2022
@slhck
Copy link
Contributor

slhck commented Jun 23, 2022

Addressed in 1ffa61c

@retokromer
Copy link
Contributor

I noticed that there are a few issues with this library, which is obviously no longer maintained. I guess it’s out of the scope of our formula to update also this.

Should we bump a revision?

@slhck
Copy link
Contributor

slhck commented Jun 23, 2022

If it was still maintained we might add it to the tap, but I agree it's out of scope.

You're right about the revision, will do so in a second.

@retokromer
Copy link
Contributor

Please wait one minute.

@retokromer
Copy link
Contributor

From my notes:

  1. I guess, we should change:
  on_linux do
    depends_on "libxv"
    depends_on "gcc" if build.with? "rubberband"
  end
  1. I am not sure that we need:
depends_on "texinfo" => :build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants