Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump json from 2.6.3 to 2.7.0 in /Library/Homebrew #16279

Merged
merged 6 commits into from Dec 4, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 1, 2023

Bumps json from 2.6.3 to 2.7.0.

Release notes

Sourced from json's releases.

v2.7.0

What's Changed

Improved

Added

Fixed

Compatibility changes

Misc

New Contributors

... (truncated)

Changelog

Sourced from json's changelog.

2023-12-01 (2.7.0)

  • Add a strict option to Generator #519
  • escape_slash option was renamed as script_safe and now also escape U+2028 and U+2029. escape_slash is now an alias of script_safe #525
  • Remove unnecessary initialization of create_id in JSON.parse() #454
  • Improvements to Hash#to_json in pure implementation generator #203
  • Use ruby_xfree to free buffers #518
  • Fix "unexpected token" offset for Infinity #507
  • Avoid using deprecated BigDecimal.new on JRuby #546
  • Removed code for Ruby 1.8 #540
  • Rename JSON::ParseError to JSON:ParserError #530
  • Call super in included hook #486
  • JRuby requires a minimum of Java 8 #516
  • Always indent even if empty #517
Commits
  • 63b074a Merge pull request #552 from flori/prepare-to-release-2-7-0
  • ca54612 Bump up 2.7.0
  • c243fe8 Fix release date
  • ce4175a Re-generate Parser.java
  • dd0fb2a Added changes for 2.7.0 and restore entries to 2.6.3 and 2.6.2
  • 10a4542 Merge branch 'Shopify-strict-dump'
  • 978ee15 Merge branch 'strict-dump' of github.com:Shopify/json into Shopify-strict-dump
  • 8741567 Merge branch 'Watson1978-create_id'
  • 173cb3a Merge branch 'create_id' of github.com:Watson1978/json into Watson1978-create_id
  • 5ab53a4 Merge branch 'vipulnsward-json-transform-hash-perf'
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels Dec 1, 2023
@apainintheneck
Copy link
Contributor

@dependabot rebase

Bumps [json](https://github.com/flori/json) from 2.6.3 to 2.7.0.
- [Release notes](https://github.com/flori/json/releases)
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md)
- [Commits](flori/json@v2.6.3...v2.7.0)

---
updated-dependencies:
- dependency-name: json
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/Library/Homebrew/json-2.7.0 branch from f20e71d to 5aa791e Compare December 3, 2023 18:38
@apainintheneck
Copy link
Contributor

Looks like there's still more Sorbet-related changes necessary to get this up and running beyond #16281.

@Bo98
Copy link
Member

Bo98 commented Dec 3, 2023

Yeah it happens when we are installing something that already ships with Ruby. json 2.7.0 technically isn't in any released Ruby stdlib yet.

Of course ideally we wouldn't be installing json here at all but RuboCop seems to do it to avoid people who break their installations with gem install json '~>1'

Easiest fix is probably similar to what we did for did_you_mean:

"did_you_mean", # RBI file is already provided by Sorbet

@MikeMcQuaid MikeMcQuaid merged commit df3a0c4 into master Dec 4, 2023
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the dependabot/bundler/Library/Homebrew/json-2.7.0 branch December 4, 2023 18:02
@MikeMcQuaid
Copy link
Member

Thanks again @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Bumping Gemfile dependencies outdated PR was locked due to age ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants