Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save in XDG_CONFIG_HOME #23

Closed
texastoland opened this issue May 23, 2020 · 2 comments · Fixed by #25
Closed

Save in XDG_CONFIG_HOME #23

texastoland opened this issue May 23, 2020 · 2 comments · Fixed by #25

Comments

@texastoland
Copy link
Contributor

I understand the backwards compatibility issue. It'd be nice to at least be able to configure the directory. Generally I'd expect it in .config/brew-aliases.

@bfontaine
Copy link
Contributor

For backward compatibility we could do something like:

if exists("~/.brew-aliases") -> use it
if is_set("$XDG_CONFIG_HOME") -> use its value
otherwise -> use "~/.brew-aliases"

Do you want to try a pull-request? Right now the base directory is defined here:

BASE_DIR = File.expand_path "~/.brew-aliases"

@texastoland
Copy link
Contributor Author

I'll try now!

bfontaine pushed a commit that referenced this issue May 27, 2020
* Save in XDG_CONFIG_HOME

Closes #23.

* Error in unalias

Fixes #24 again. The command logic was inverted. I had also introduced a bug changing BASE_DIR to a Pathname.

* Replace duplicate assignment with rescue
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants