Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl formula does not install zsh completions #170210

Closed
4 tasks done
Mellbourn opened this issue Apr 27, 2024 · 0 comments · Fixed by #170211
Closed
4 tasks done

curl formula does not install zsh completions #170210

Mellbourn opened this issue Apr 27, 2024 · 0 comments · Fixed by #170211
Labels
bug Reproducible Homebrew/homebrew-core bug outdated PR was locked due to age

Comments

@Mellbourn
Copy link

brew gist-logs <formula> link OR brew config AND brew doctor output

❯ brew config
HOMEBREW_VERSION: 4.2.19
ORIGIN: https://github.com/Homebrew/brew
HEAD: 54bea636b41f7953c01a7da5f488f08c1b42ffd1
Last commit: 5 days ago
Core tap JSON: 26 Apr 17:00 UTC
Core cask tap JSON: 26 Apr 17:00 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: code -wr
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 12
Homebrew Ruby: 3.1.4 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/bin/ruby
CPU: dodeca-core 64-bit arm_blizzard_avalanche
Clang: 15.0.0 build 1500
Git: 2.44.0 => /opt/homebrew/bin/git
Curl: 8.4.0 => /usr/bin/curl
macOS: 14.4.1-arm64
CLT: 15.3.0.0.1.1708646388
Xcode: 15.3
Rosetta 2: false

Verification

  • My brew doctor output says Your system is ready to brew. and am still able to reproduce my issue.
  • I ran brew update and am still able to reproduce my issue.
  • I have resolved all warnings from brew doctor and that did not fix my problem.
  • I searched for recent similar issues at https://github.com/Homebrew/homebrew-core/issues?q=is%3Aissue and found no duplicates.

What were you trying to do (and why)?

Installed curl and expected command line completions to be installed

What happened (include all command output)?

no zsh completions installed

What did you expect to happen?

zsh completions installed

Step-by-step reproduction instructions (by running brew commands)

I execute `brew install curl` and restart the shell. I don't get any command line completions.

I'm using zsh 5.9

When I search under `/opt/homebrew` for `_curl` I get only two hits


❯ fd -uuu '_curl\b'
  share/zsh/functions/_curl
  Cellar/zsh/5.9/share/zsh/functions/_curl

The first is a link to the second. The complete content of the second is:

  #compdef curl

  # As of 7.43.0, curl upstream provides its own _curl definition.  This
  # definition is provided as a fallback, and should be installed later
  # in $fpath than the curl-provided definition of _curl.

  _gnu_generic || _urls "$@"

Running fd -uuu '\b_curl\b' from the root folder does not find any other completion files.

Reinstalling curl with brew reinstall curl does not alter this.

When I look at the homebrew code for installing curl, I find no mention of completions. Compare this to other tools, like ripgrep or fd that do mention completions.

@Mellbourn Mellbourn added the bug Reproducible Homebrew/homebrew-core bug label Apr 27, 2024
carlocab added a commit that referenced this issue Apr 27, 2024
These used to be installed by default, but upstream changes now require
passing extra flags to `configure` to make sure that they are installed.

See curl/curl#13255.

Fixes #170210.
@github-actions github-actions bot added the outdated PR was locked due to age label May 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/homebrew-core bug outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant