Octave 9.1.0 opengl bug interacting with qt6-6.7.0

[chrisjohgorman]

brew gist-logs <formula> link OR brew config AND brew doctor output

I do not use homebrew.  This is an attempt at getting an upstream patch in to fix crashes for homebrew users.

Verification

• My brew doctor output says Your system is ready to brew. and am still able to reproduce my issue.
• I ran brew update and am still able to reproduce my issue.
• I have resolved all warnings from brew doctor and that did not fix my problem.
• I searched for recent similar issues at https://github.com/Homebrew/homebrew-core/issues?q=is%3Aissue and found no duplicates.

What were you trying to do (and why)?

I can't seem to get your system to accept my patch. Here is my best go at it. In the following code block the patch to octave.rc should (I hope) download a patch from savannah.gnu.org and apply it to your source tree prior to build. This should fix the bug with octave 9.1.0 interacting with qt6-6.7.0.

diff --git a/Formula/o/octave.rb b/Formula/o/octave.rb
index 60f8aea563d..c11a87df330 100644
--- a/Formula/o/octave.rb
+++ b/Formula/o/octave.rb
@@ -81,6 +81,12 @@ class Octave < Formula
 
   fails_with gcc: "5"
 
+  # Fix opengl-partial-update bug causing crashes on figure() and plot().
+  patch do
+    url "https://file.savannah.gnu.org/file/bug65605-qt6-opengl-partial-update.patch?file_id=55978"
+    sha256 "4f258a90dcb6b5d7f1af466dfc2b2fd6413968070ab224e4b368d355ec257ca9"
+  end
+
   def install
     # Default configuration passes all linker flags to mkoctfile, to be
     # inserted into every oct/mex build. This is unnecessary and can cause

What happened (include all command output)?

I got a report from a homebrew user in the octave mailing lists saying his build crashes.

What did you expect to happen?

Opening octave and running figure() will cause a crash. With this patch applied a figure window will open instead.

Step-by-step reproduction instructions (by running brew commands)

No instructions here.  Just trying to help out.

[SMillerDev]

I can't seem to get your system to accept my patch.

Can you link the pull request? It'll be easier to fix that up than make a new one (and you'll get proper credit)

[chrisjohgorman]

Hi Sean, I'll try to clone the repository in my github account and then make a pull request. I thought it might be faster the other way. Take care, Chris

…

On Thu, May 2, 2024 at 11:17 AM Sean Molenaar ***@***.***> wrote: I can't seem to get your system to accept my patch. Can you link the pull request? It'll be easier to fix that up than make a new one (and you'll get proper credit) — Reply to this email directly, view it on GitHub <#170616 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG76X4Z4IKWOFGQ37AMJ2GTZAJKIPAVCNFSM6AAAAABHD4ZNP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQG44DOMZRGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[carlocab]

Thanks for reporting this. #170657 will merge soon.

Please ask your users to do

brew update && brew reinstall octave

in about half an hour.

[sunilshah]

I can confirm it works on Mac OS 14.4.1