Merge pull request #2522 from homebridge/homebridge-version-check

Do not prevent Homebridge loading plugins based on Homebridge engines req.
homebridge · Apr 27, 2020 · 3e35b91 · 3e35b91
2 parents 2383be3 + 2d19a77
commit 3e35b91
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "homebridge",
   "description": "HomeKit support for the impatient",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "scripts": {
     "dev": "DEBUG=* ./bin/homebridge -D -P example-plugins/ || true",
     "lint": "eslint 'src/**/*.{js,ts,json}'",

diff --git a/src/plugin.ts b/src/plugin.ts
@@ -141,8 +141,10 @@ export class Plugin {
 
     // make sure the version is satisfied by the currently running version of HomeBridge
     if (!satisfies(getVersion(), versionRequired, { includePrerelease: true })) {
-      throw new Error(`Plugin ${this.pluginPath} requires a HomeBridge version of ${versionRequired} which does \
-not satisfy the current HomeBridge version of ${getVersion()}. You may need to upgrade your installation of HomeBridge.`);
+      // TODO - change this back to an error
+      log.error(`The plugin "${this.pluginName}" requires a Homebridge version of ${versionRequired} which does \
+not satisfy the current Homebridge version of ${getVersion()}. You may need to update this plugin (or Homebridge) to a newer version. \
+You may face unexpected issues or stablity problems running this plugin.`);
     }
 
     // make sure the version is satisfied by the currently running version of Node