Match existing hook without payload secret #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give a brief overview)
Change the desired hook config used to match against existing hooks to not include the secret property if its value is undefined.
Without this change, the _.isMatch function is not able to find a match in the existing pipelines, and attempts to create the webhook again, resulting in an api error.
The error returned by the resource before this changes looked like the following:
Is there anything specific you would like reviewers to focus on?
No