Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.0.3: fix(project): fix terser package version #70

Merged
merged 2 commits into from
Jun 30, 2019
Merged

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Jun 30, 2019

What does this PR do?

Since #63 , the project is using terser-webpack-plugin to minify the files. The plugin requires terser@^4.0.0, the core library that actually does the whole thing.

A few hours ago, terser@4.0.1 was released... with a bug on the source map generation; this causes webpack to silently exit without any error nor notification.

Forcing the project to install terser@4.0.0 seems to fix the issue.

I'll keep an eye for when it gets fixed and I'll remove the dependency.

How should it be tested manually?

Try to build a project for production using master and this branch.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 254

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 251: 0.0%
Covered Lines: 604
Relevant Lines: 604

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants