Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update character counter with correct lengths #829

Closed
jewel-andraia opened this issue Mar 11, 2014 · 3 comments
Closed

Update character counter with correct lengths #829

jewel-andraia opened this issue Mar 11, 2014 · 3 comments

Comments

@jewel-andraia
Copy link
Collaborator

http://www.reddit.com/r/RESissues/comments/206gfk/bug_incorrect_character_counter_limit_above_text/cg08xq3?context=3
#157

@jewel-andraia
Copy link
Collaborator Author

note different limit on text posts for subreddits which are text-only.

please add pointers to reddit's definitions in RES code for reference
edit for clarity: i.e.

commentPreview.js

MAX_LENGTHS: {
    WIKI: 50000,  // defined @ http://github.com/reddit/reddit/files/SOMECOMMIT/r2/lib/models/posts.py#L123 

@kevinji
Copy link
Collaborator

kevinji commented Mar 31, 2014

Also #465

@matheod
Copy link
Collaborator

matheod commented Apr 19, 2014

https://github.com/reddit/reddit/blob/3bfe0a2513495f8e667f60ca3efce03f97990e51/r2/r2/lib/validator/validator.py#L574 + https://github.com/reddit/reddit/blob/3bfe0a2513495f8e667f60ca3efce03f97990e51/r2/r2/lib/validator/validator.py#L604-L607

I.e. :

  • 10 000 (=L) for simple comments
  • 15 000 (=L*1.5) for post in subreddit allowing link post
  • 40 000 (=L*4) for post in subreddit self post only

jewel-andraia added a commit that referenced this issue May 11, 2014
Fix #829 - Update character counter with correct lengths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants