Add Context module #1052
Add Context module #1052
Conversation
| } | ||
| }, | ||
| setDefaultContext: function() { | ||
| $(".bylink").each(function() { |
There was a problem hiding this comment.
@honestbleeps think it's worth using RESUtils.forEachChunked?
There was a problem hiding this comment.
yes, anything running on all comments should use chunking or UI will freeze on large pages
There was a problem hiding this comment.
well, this function is only called on inbox. so max .. 100? but it wouldn't hurt to chunk
There was a problem hiding this comment.
ah my bad.. max 100 is probably fine to leave as-is
On Tue, May 13, 2014 at 4:39 PM, Andy Tuba notifications@github.com wrote:
In lib/modules/context.js:
}if ((RESUtils.pageType() === 'inbox') && !isNaN(this.options.defaultContext.value) && this.options.defaultContext.this.setDefaultContext();}}- },
- addViewFullContext: function() {
if(location.search !== "?context=10000") {var pInfobar = document.querySelector(".infobar:not(#searchexpando) p");if(pInfobar) {pInfobar.innerHTML += ' <a href="?context=10000">view the full context</a> →';}}- },
- setDefaultContext: function() {
$(".bylink").each(function() {well, this function is only called on inbox. so max .. 100? but it
wouldn't hurt to chunk—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1052/files#r12610307
.
There was a problem hiding this comment.
(note for posterity) plus it's just changing the href attribute, so not serious DOM manipulation / repaints
There was a problem hiding this comment.
(note for posterity) only 1ms for 100 context link
Fix #437
Fix #291