Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated beta releases (for Chrome) #2946

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

erikdesjardins
Copy link
Collaborator

@erikdesjardins erikdesjardins commented May 7, 2016

Resolves #2728.

This does two things:

  • For tags with an odd minor version number1 (to be used as beta releases), automatically builds and publishes the Chrome version to a beta listing
  • For all version number tags, builds all targets and uploads the artifacts to a new GitHub release Automated GitHub release creation #3181

1: Actually, we might as well release all versions to the beta channel, so beta users don't have to switch back to the main extension for normal releases.

Todo

branches:
only:
- master
- /^v[0-9]/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is actually restricting all builds/tests to only those branches, not just deploys, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but it won't effectively change anything because it only applies to branches and tags in this repo (PRs are always built).

Mainly, it's the simplest way to avoid building (and then trying to deploy) tags that don't look like version numbers.

@Ajedi32
Copy link
Contributor

Ajedi32 commented May 10, 2016

Seems like a reasonable idea. I've already been doing something similar to this by just using a version of RES that I built myself on my computer.

Maybe this would give more non-technical users a chance to test upcoming changes though, which could help avoid situations like in the previous release where few people were aware of the upcoming changes to night mode until after the release. Getting early feedback from users is a good thing.

For tags with an odd minor version number (to be used as beta releases)

Is there a reason you're suggesting using odd version numbers here as beta releases instead of the SemVer convention of appending -beta.0, -beta.1, etc to the version number?

From http://semver.org/#spec-item-9:

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric identifiers MUST NOT include leading zeroes. Pre-release versions have a lower precedence than the associated normal version. A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version. Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92.

@jewel-andraia
Copy link
Collaborator

Is there a reason you're suggesting using odd version numbers here as beta releases instead of the SemVer convention of appending -beta.0, -beta.1, etc to the version number?

Yes, browsers only allow numbers and periods in version numbers.

@erikdesjardins erikdesjardins force-pushed the deployment branch 2 times, most recently from 36c00bc to 8cdf252 Compare June 21, 2016 22:13
@erikdesjardins erikdesjardins added this to the v4.7 milestone Jul 8, 2016
@erikdesjardins erikdesjardins changed the title [RFC] Automated beta releases (for Chrome) Automated beta releases (for Chrome) Jul 9, 2016
@jewel-andraia
Copy link
Collaborator

Store listing / disclaimer / instructions text: https://docs.google.com/document/d/1uEyNRkB4Vg8NSgXt_tGDJ-Seth8rAsI3zC26QC7rk18/edit?usp=sharing

@erikdesjardins erikdesjardins merged commit 390634a into honestbleeps:master Jul 26, 2016
@erikdesjardins erikdesjardins deleted the deployment branch July 26, 2016 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants