-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated beta releases (for Chrome) #2946
Conversation
84bfec4
to
7c7ce3a
Compare
branches: | ||
only: | ||
- master | ||
- /^v[0-9]/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this is actually restricting all builds/tests to only those branches, not just deploys, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but it won't effectively change anything because it only applies to branches and tags in this repo (PRs are always built).
Mainly, it's the simplest way to avoid building (and then trying to deploy) tags that don't look like version numbers.
Seems like a reasonable idea. I've already been doing something similar to this by just using a version of RES that I built myself on my computer. Maybe this would give more non-technical users a chance to test upcoming changes though, which could help avoid situations like in the previous release where few people were aware of the upcoming changes to night mode until after the release. Getting early feedback from users is a good thing.
Is there a reason you're suggesting using odd version numbers here as beta releases instead of the SemVer convention of appending From http://semver.org/#spec-item-9:
|
Yes, browsers only allow numbers and periods in version numbers. |
7c7ce3a
to
4712614
Compare
36c00bc
to
8cdf252
Compare
8cdf252
to
55f578d
Compare
55f578d
to
2ab2730
Compare
Store listing / disclaimer / instructions text: https://docs.google.com/document/d/1uEyNRkB4Vg8NSgXt_tGDJ-Seth8rAsI3zC26QC7rk18/edit?usp=sharing |
e65dd92
to
2511f8f
Compare
2511f8f
to
eea5ac3
Compare
Resolves #2728.
This does two things:
odd minor version number1 (to be used as beta releases), automatically builds and publishes the Chrome version to a beta listingFor all version number tags, builds all targets and uploads the artifacts to a new GitHub releaseAutomated GitHub release creation #31811: Actually, we might as well release all versions to the beta channel, so beta users don't have to switch back to the main extension for normal releases.
Todo