Use url instead of inner text #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix the bug caused by the trending subreddits update.
| @@ -333,6 +333,7 @@ modules['filteReddit'] = { | |||
| } | |||
| // var RALLre = /\/r\/all\/?(([\w]+)\/)?/i; | |||
| // var onRALL = RALLre.exec(location.href); | |||
| var urlRegex = /\/r\/(.*)\//; | |||
There was a problem hiding this comment.
I think I'd personally prefer this to be /\/r\/([-\w\.]*)\/?/ to make the last slash optional and to make the regex a little more restrictive.
There was a problem hiding this comment.
How about using the existing RESUtils.matchRE instead of writing a new regexp?
|
I have updated it according to the comments. Although I wasn't sure whether I should use .exec or .match because RESUtils.currentSubreddit uses .match when using RESUtils.matchRE. |
jewel-andraia
added a commit
that referenced
this pull request
Apr 12, 2014
Use url instead of inner text for pulling a post's "posted to" subreddit from frontpage/all/multireddit for filteReddit by subreddit
jewel-andraia
referenced
this pull request
Apr 12, 2014
Ads by redditads does not have a domain, generating an error
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #915.