Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number to honeybadger.js file comment #19

Closed
zmillman opened this issue Mar 17, 2014 · 0 comments
Closed

Add version number to honeybadger.js file comment #19

zmillman opened this issue Mar 17, 2014 · 0 comments

Comments

@zmillman
Copy link

This is a pretty standard practice which makes it easier for developers to see what version of the javascript they've copied into their application.

I assume that most Rails developers will actually be copying the un-minified source to an assets folder and letting their asset compiler handle the minification with the rest of their application code. For the developers who use the straight minified version, they should still be able to figure out what version they have without doing a file-search.

Here's an example from jquery.cookie.js:

/*!
 * jQuery Cookie Plugin v1.3.1
 * https://github.com/carhartl/jquery-cookie
 *
 * Copyright 2013 Klaus Hartl
 * Released under the MIT license
 */
joshuap pushed a commit that referenced this issue Jul 10, 2014
@joshuap joshuap closed this as completed Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants