Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure shipjs workflows do not modify package-lock.json #787

Merged
merged 2 commits into from May 16, 2022
Merged

fix: make sure shipjs workflows do not modify package-lock.json #787

merged 2 commits into from May 16, 2022

Conversation

subzero10
Copy link
Member

@subzero10 subzero10 commented May 11, 2022 •
edited

Last shipjs prepare failed because working tree was not empty. I suspect it's because npm install modified the package-lock.json file. We won't have this problem with npm ci.

@subzero10 subzero10 requested a review from joshuap May 11, 2022 19:40
@subzero10 subzero10 self-assigned this May 11, 2022
@subzero10 subzero10 requested a review from shalvah May 14, 2022 13:57
@subzero10 subzero10 merged commit b1568ff into master May 16, 2022
@subzero10
Copy link
Member Author

@shipjs prepare

@github-actions
Copy link
Contributor

@subzero10 shipjs prepare done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalvah shalvah shalvah approved these changes

@joshuap joshuap Awaiting requested review from joshuap

Assignees

@subzero10 subzero10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@subzero10 @shalvah