-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added ESM support #828
base: master
Are you sure you want to change the base?
Conversation
(cherry picked from commit a86d4d3)
Integration tests are failing. Looking into it. |
# Conflicts: # README.md # package.json # rollup.config.js # tsconfig.base.json
Fixes: #823
@subzero10 what will happen if someone is using this package in an esm module in Node? Will they potentially end up with the browser version instead of the server version? |
I had the same question my self. It's very confusing to say the least:
That's why I opted for the simplest non-breaking change, even though it's recommended to avoid 🤷 . |
Status
READY
Description
Fixes #823.