Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toNative() vs toArray() #21

Open
MrHash opened this issue Jun 7, 2016 · 2 comments
Open

toNative() vs toArray() #21

MrHash opened this issue Jun 7, 2016 · 2 comments
Labels

Comments

@MrHash
Copy link
Contributor

MrHash commented Jun 7, 2016

Currently both implementations seem to be very similar. In order to avoid confusion we should be clear on what to use as it seems toArray() is sufficient.

@MrHash MrHash added the question label Jun 7, 2016
@graste
Copy link
Member

graste commented Jun 24, 2016

They turned out to be in fact similiar now while they were not when we started it. I had a look at the current implementation and the usage in projects and I think we can get rid of one of the methods. While we're at it we might want to introduce a ArrayableInterface or something instead of extending the base Object? This has implication on the automatic setting of properties via constructors though and might be a bigger change. Object and Configurable have leaked into honeybee. Any ideas how to proceed?

@MrHash
Copy link
Contributor Author

MrHash commented Jun 24, 2016

I guess we could get better test coverage first then implement such changes but in principle, I'm in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants