-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of libhoney.Client should be documented in changelog #55
Comments
Yes! Thank you; that should have happened in the first place. |
Erp. Updating that changelog felt awfully familiar... The changes are already pending in an existing not-yet-reviewed PR #52 I'll bump the review request and get it merged. |
I updated the changelog in b76b6f0 but it occurs to me that perhaps some more text around the Do you have any suggestions on the type of language that would be useful there? Maybe something like this?
|
That sounds like a great idea! It might be worth saying that this would affect folks who are manually calling |
Closing this as there has been no recent activity and it appears it was covered in changelog updates. Feel free to request a re-open if it’s still relevant. |
This commit changed
beeline.Init()
so that it doesn't call the globallibhoney.Init
. This broke some of our services that are using both libhoney events and beeline traces while they migrate to libhoney.Please can you document this change in the changelog?
The text was updated successfully, but these errors were encountered: