Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: add node 18 to CI matrix #610

Merged
merged 1 commit into from Aug 4, 2022
Merged

maint: add node 18 to CI matrix #610

merged 1 commit into from Aug 4, 2022

Conversation

vreynolds
Copy link
Contributor

Which problem is this PR solving?

  • node 18 has been out since April 馃榿

Short description of the changes

  • test node 18 in CI
  • also update default version to one that's in maintenance LTS

@vreynolds
maint: add node 18 to CI matrix
2576f0a 
also update default version to one that's in maintenance LTS
@vreynolds vreynolds requested a review from a team as a code owner August 3, 2022 16:31
@vreynolds vreynolds added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. merge at will Reviewer can merge the PR once reviewed. labels Aug 3, 2022
@vreynolds vreynolds self-assigned this Aug 3, 2022
MikeGoldsmith
MikeGoldsmith approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@vreynolds vreynolds merged commit d20b88e into main Aug 4, 2022
@vreynolds vreynolds deleted the vera.add-node-18 branch August 4, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@vreynolds vreynolds

Labels
merge at will Reviewer can merge the PR once reviewed. type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vreynolds @MikeGoldsmith