Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add console warnings for misconfigured options #49

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Dec 16, 2022

Which problem is this PR solving?

Adds missing console warnings for misconfigured options.

Short description of the changes

  • Add warnings for missing API keys or service, dataset for non-classic API key and no dataset for classic API key
  • Ignores the too-many-statements lint rule in HoneycombOptions

How to verify that this has the expected result

Warnings are printed for misconfigured options.

@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Dec 16, 2022
@MikeGoldsmith MikeGoldsmith added this to the Beta milestone Dec 16, 2022
@MikeGoldsmith MikeGoldsmith requested a review from a team December 16, 2022 13:52
@MikeGoldsmith MikeGoldsmith self-assigned this Dec 16, 2022
Copy link
Contributor

@emilyashley emilyashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! ✨

@MikeGoldsmith MikeGoldsmith merged commit 8f6c370 into main Jan 9, 2023
@MikeGoldsmith MikeGoldsmith deleted the mike/warnings branch January 9, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add debug & console warnings
2 participants