Upgrade superagent to remove vulnerability #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superagent <3.7.0 is vulnerable to a denial-of-service attack. See https://snyk.io/vuln/npm:superagent:20170807 for details
|
awesome. We've only ever built/tested on travis-ci with node 6 (and locally with higher versions), so I don't feel bad about dropping <4 at all. That said, let me check :) |
|
alas, we don't have that data. going to open a PR after landing this to start recording it (adding the node version to the user agent string), but I think "ask forgiveness" is appropriate here :) |
|
馃帀 |
This was referenced Jul 20, 2018
toshok
added a commit
to honeycombio/beeline-nodejs
that referenced
this pull request
Jul 20, 2018
honeycombio/libhoney-js#26 bumped libhoney's superagent dep to fix a vulnerability. libhoney 1.1.2 was published containing this fix. Let's bump our libhoney dep to get the fix here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team Honeycomb 馃憢
We (Snyk) just started checking out Honeycomb, and noticed that the version of superagent used in this lib has a low-severity vulnerability.
This small PR updates superagent to a non-vulnerable version. From the superagent release notes it looks like biggest potential impact of jumping from 2.x to 3.x is the Node 4+ requirement. I couldn't tell from this repo whether that is going to be an issue for you, so figured I'd raise the PR in any case 馃槃