fix(method-override): remove un-needed import of URLSearchParams in method override middleware #2679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR simply removes the
URLSearchParams
import from the node-specific packageurl
.when running hono and using the method override middleware in cloudflare workers, wrangler complains about the use of the
url
package. it prompts you to add thenode_compat
flag.this seems a bit erroneous to me, since node has had
URLSearchParams
as a global since version 10. maybe i'm missing something specific about other runtimes, but all tests pass.please nuke this PR if i'm flat-out wrong ;)
bun denoify
to generate files for Denobun run format:fix && bun run lint:fix
to format the code