Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(secure-headers): don't use Partial for the options #2713

Merged
merged 2 commits into from
May 18, 2024

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented May 18, 2024

It is the same reason as #2712 .

Sometimes Partial is used instead of making all option values optional, but this is not necessary in this case.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun denoify to generate files for Deno
  • bun run format:fix && bun run lint:fix to format the code

@yusukebe yusukebe merged commit 9540e69 into main May 18, 2024
10 checks passed
@yusukebe yusukebe deleted the refactor/secure-headers-dont-use-partial branch May 18, 2024 21:55
nicolewhite pushed a commit to autoblocksai/cli that referenced this pull request May 20, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [hono](https://hono.dev/) ([source](https://togithub.com/honojs/hono))
| [`4.3.6` ->
`4.3.8`](https://renovatebot.com/diffs/npm/hono/4.3.6/4.3.8) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/hono/4.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/hono/4.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/hono/4.3.6/4.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/hono/4.3.6/4.3.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/hono (hono)</summary>

### [`v4.3.8`](https://togithub.com/honojs/hono/releases/tag/v4.3.8)

[Compare
Source](https://togithub.com/honojs/hono/compare/v4.3.7...v4.3.8)

#### What's Changed

- test(validator): compatibility with Node.js `v20.13.1` by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[honojs/hono#2682
- refactor(utils/jwt): remove some `any` by
[@&#8203;fzn0x](https://togithub.com/fzn0x) in
[honojs/hono#2684
- refactor(timing): don't use `Partial` for the options by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[honojs/hono#2712
- refactor(secure-headers): don't use `Partial` for the options by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[honojs/hono#2713
- fix(context): Retain all cookies when passing `ResponseInit` to
`c.body` by [@&#8203;codeflows](https://togithub.com/codeflows) in
[honojs/hono#2690
- fix(hono-jsx): make ref unrequried for forward ref by
[@&#8203;dygy](https://togithub.com/dygy) in
[honojs/hono#2715

#### New Contributors

- [@&#8203;fzn0x](https://togithub.com/fzn0x) made their first
contribution in
[honojs/hono#2684
- [@&#8203;codeflows](https://togithub.com/codeflows) made their first
contribution in
[honojs/hono#2690
- [@&#8203;dygy](https://togithub.com/dygy) made their first
contribution in
[honojs/hono#2715

**Full Changelog**:
honojs/hono@v4.3.7...v4.3.8

### [`v4.3.7`](https://togithub.com/honojs/hono/releases/tag/v4.3.7)

[Compare
Source](https://togithub.com/honojs/hono/compare/v4.3.6...v4.3.7)

#### What's Changed

- doc(ssg): Define the default value for Content-Type by
[@&#8203;watany-dev](https://togithub.com/watany-dev) in
[honojs/hono#2666
- feat(aws-lambda): add alb event processor by
[@&#8203;yiss](https://togithub.com/yiss) in
[honojs/hono#2657
- feat(utils/cookie): allow setting cookie SameSite attribute in
lowercase too by
[@&#8203;BlankParticle](https://togithub.com/BlankParticle) in
[honojs/hono#2668
- fix(method-override): remove un-needed import of URLSearchParams in
method override middleware by [@&#8203;f5io](https://togithub.com/f5io)
in
[honojs/hono#2679

#### New Contributors

- [@&#8203;yiss](https://togithub.com/yiss) made their first
contribution in
[honojs/hono#2657
- [@&#8203;BlankParticle](https://togithub.com/BlankParticle) made their
first contribution in
[honojs/hono#2668
- [@&#8203;f5io](https://togithub.com/f5io) made their first
contribution in
[honojs/hono#2679

**Full Changelog**:
honojs/hono@v4.3.6...v4.3.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant