-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PouchDB support #490
PouchDB support #490
Conversation
BREAKING CHANGE: No intended breaking changes, just making sure not to break things accidentally
@@ -7,30 +7,31 @@ var log = require('npmlog') | |||
var mkdirp = require('mkdirp') | |||
|
|||
module.exports = function (options) { | |||
var projectPath = options.path || process.cwd() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn’t find any place where options.path
is used, I think it was part of our old Hoodie’s test setup.
Unless any objections, I’ll merge this in this Friday – and probably live stream how I do it a la https://www.youtube.com/watch?v=9FBvpKllTQQ |
That would be awesome, gregor! :)
|
Awesome, thanks for your work! On 19 April 2016 at 18:17, Sebastian Pancia notifications@github.com
|
This is the current tent branch that our new starter app uses since months now, I just cleaned up the commits to make it ready for merging. I’d like to merge this into
next
or even master to clean things up and stop working with npm installs from GitHub, and install from the registry instead.I agree that the code base is not ideal yet, e.g. the way internal modules
store
andaccount
are initialised. But I would like to merge this in first as it works ™️ and then collaborate on improving the code.after merge
@hoodie/server
, commit withBREAKING CHANGE: ...
@hoodie/server
on npmtent
andcamp
branches