Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PouchDB support #490

Merged
merged 7 commits into from
Apr 22, 2016
Merged

PouchDB support #490

merged 7 commits into from
Apr 22, 2016

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Apr 15, 2016

This is the current tent branch that our new starter app uses since months now, I just cleaned up the commits to make it ready for merging. I’d like to merge this into next or even master to clean things up and stop working with npm installs from GitHub, and install from the registry instead.

I agree that the code base is not ideal yet, e.g. the way internal modules store and account are initialised. But I would like to merge this in first as it works ™️ and then collaborate on improving the code.


after merge

@@ -7,30 +7,31 @@ var log = require('npmlog')
var mkdirp = require('mkdirp')

module.exports = function (options) {
var projectPath = options.path || process.cwd()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn’t find any place where options.path is used, I think it was part of our old Hoodie’s test setup.

@gr2m
Copy link
Member Author

gr2m commented Apr 19, 2016

Unless any objections, I’ll merge this in this Friday – and probably live stream how I do it a la https://www.youtube.com/watch?v=9FBvpKllTQQ

@sebbel
Copy link

sebbel commented Apr 19, 2016 via email

@sergi
Copy link

sergi commented Apr 21, 2016

Awesome, thanks for your work!

On 19 April 2016 at 18:17, Sebastian Pancia notifications@github.com
wrote:

That would be awesome, gregor! :)


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#490 (comment)

@gr2m gr2m merged commit e8ec38e into next Apr 22, 2016
@gr2m gr2m removed the in progress label Apr 22, 2016
@gr2m gr2m deleted the camp branch April 24, 2016 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants