Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in preprocessing.py -> get_read_paths() (version 1.4.3) #175

Closed
AlexSurnov opened this issue Feb 21, 2023 · 1 comment
Closed

bug in preprocessing.py -> get_read_paths() (version 1.4.3) #175

AlexSurnov opened this issue Feb 21, 2023 · 1 comment

Comments

@AlexSurnov
Copy link

AlexSurnov commented Feb 21, 2023

Dear developers of CITE-Seq-Count,
Thank you for your product.

I installed CITE-Seq-Count version 1.4.3 and I think that there is an inconsistency in the file preprocessing.py. Namely, the function get_read_paths contains the line if len(read1_path) != len(read2_path): instead of if len(_read1_path) != len(_read2_path):. To my understanding, this is a crucial bug, which prevents proper input reading. When the incorrect line is executed, the script compares the number of characters in the input strings instead of the number of elements in the split strings generated by the read1_path.split.

All the best
Alex Surnov

@Hoohm
Copy link
Owner

Hoohm commented Jul 22, 2023

This is correct, this bug is fixed in 1.4.5

@Hoohm Hoohm closed this as completed Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants