Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not Working in IE 11 #37

Closed
edisonaugusthy opened this issue Aug 23, 2019 · 5 comments
Closed

Not Working in IE 11 #37

edisonaugusthy opened this issue Aug 23, 2019 · 5 comments
Labels
need testing Needs to be tested before merging onto production

Comments

@edisonaugusthy
Copy link
Contributor

Describe the bug
App Crashes in IE 11

To Reproduce
Steps to reproduce the behavior:

  1. Open Site in IE11
  2. See error

Expected behavior
the view should be the same as in chrome.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 7
  • Browser : IE
  • Version 11
@liyasthomas
Copy link
Member

liyasthomas commented Aug 23, 2019 •
edited

I afraid IE 11 lacks ES6 support. And thus broke the app. I regret any inconvince caused. Let me do some more tests and will let you know

@liyasthomas liyasthomas added the need testing Needs to be tested before merging onto production label Aug 23, 2019
@AndrewBastin
Copy link
Member

Thanks for opening the issue...

I am pretty sure this can be resolved by resolving #31 .

Until then it's impractical to work on IE support while dropping all the niceties of modern JavaScript.

@diego81b
Copy link

Yeah, vue-cli comes with babel transpiling (more or less @AndrewBastin the same happens in create-react-app).

For working with IE11 we have to pay attention with modern CSS too (for example flex, but there are many others) so question is if we really want the project "IE11 compliant".

Personally i don't find any reason to make it 100% compatible with IE11 also due to the fact that Chrome, Brave and Firefox are free to use browsers for any OS

@AndrewBastin
Copy link
Member

Yeah, vue-cli comes with babel transpiling (more or less @AndrewBastin the same happens in create-react-app).

For working with IE11 we have to pay attention with modern CSS too (for example flex, but there are many others) so question is if we really want the project "IE11 compliant".

Personally i don't find any reason to make it 100% compatible with IE11 also due to the fact that Chrome, Brave and Firefox are free to use browsers for any OS

@diego81b yeah, well the issue opened here is that the app doesn't work on IE11, lending some basic support doesn't hurt.

I don't think we need full IE11 compliance, because that will make it difficult or limit the stuff we can do with this app, but some graceful fallbacks will be nice.

Well, another kinda being a wrench to this is that I am kinda working on making Postwoman kinda run as a lightweight cross-platform native desktop app (still by not using Electron) instead by depending on system webviews, in Windows that will be IE, so well, I kinda would love 100% IE compliance 😅

This was referenced Aug 24, 2019
Merged
Merged
@liyasthomas
Copy link
Member

Closing the issue since #51 solved it

AndrewBastin pushed a commit that referenced this issue Apr 11, 2023
@balub
refactor: adding JSON import/export functions to UserCollections modu…
be46ed2 
…le (HBE-169) (#37)

* feat: created exportUserCollectionsToJSON mutation for UserCollection module

* chore: added comments to export functions

* chore: added type and user ownership checking to creation methods

* chore: replaced request property with spread request object instead

* chore: completed all changes requested in inital review of PR

* chore: explicitly exporting request title in export function

* chore: explicitly exporting request title in export function

* chore: added codegen folder to gitignore

* chore: removed gql-code gen file from repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need testing Needs to be tested before merging onto production
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AndrewBastin @diego81b @liyasthomas @edisonaugusthy