Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue template #31

Closed
diego81b opened this issue Aug 23, 2019 · 13 comments
Closed

Vue template #31

diego81b opened this issue Aug 23, 2019 · 13 comments
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@diego81b
Copy link

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Why don't move to a standard vue template using vue-cli and benefit of the base configuration ?

Describe alternatives you've considered
Maybe could be cool to move to v3 of vue and starting with Composition API

Additional context
No

@liyasthomas
Copy link
Member

liyasthomas commented Aug 23, 2019

Rewriting all of Postwoman to latest vue is also a prime concern for me - but I can't afford to break any features. Will surely consider your advice 👐

@liyasthomas liyasthomas added feature New feature or request help wanted Extra attention is needed labels Aug 23, 2019
@AndrewBastin
Copy link
Member

Well, I don't think it will have that big of a deal on any of the features we have right now, just that it affects the current PRs....

I think we should work on a vue-cli build, build it in a separate branch perhaps...

I am not a Vue guy (React ftw 😛 ) so anyone willing to take up the task feel free to make a PR...

@diego81b
Copy link
Author

Well. i'm pretty comfortable with vue ecosystem; my doubt is only the merge because the project scaffold of vue template will change the project folder structure.

Anyway i'll be glad to contribute even if i don't have so much time, but if you consider this issue not a priority feel free to assign to me and i'll try to work on it

best regards
Diego

@AndrewBastin
Copy link
Member

@diego81b Let it change the project structure, that's fine, please be free to work on your PR but we should assign it to a separate branch so existing PRs can still be worked on and integrated before we merge it to master...

@liyasthomas
Copy link
Member

Keep seperate branches for development ✌️

@NBTX
Copy link
Contributor

NBTX commented Aug 23, 2019

I love Vue and have used it frequently - perhaps I could fork the project (and anyone else interested in helping to port this to Vue) could work on the fork. Then we can just PR into the main repo when it's done?

@NBTX
Copy link
Contributor

NBTX commented Aug 23, 2019

Also we should totally make a PWA!

@liyasthomas
Copy link
Member

I would love to migrate to Vue. Need some helping hands. Btw, PWA support has already been implemented. But Vue integration would enhance it. No offense.

@diego81b
Copy link
Author

@NBTX
my intention was to use this https://github.com/chrisvfritz/vue-enterprise-boilerplate
appropriately resized for our purpose

i have this issue assigned but feel free to work on your fork add maybe add me as collaborator

@NBTX
Copy link
Contributor

NBTX commented Aug 23, 2019

@liyasthomas Just noticed the PWA support -- neat!
@diego81b Okay. I'll take a look at the boilerplate. I've created the fork and sent you and @liyasthomas collaborator invites: https://github.com/NBTX/postwoman-vue

@liyasthomas
Copy link
Member

Closing the issue since #51 solved it

@liyasthomas
Copy link
Member

@all-contributors please add NBTX for code

@allcontributors
Copy link
Contributor

@liyasthomas

I've put up a pull request to add @NBTX! 🎉

AndrewBastin pushed a commit that referenced this issue Apr 11, 2023
* chore: removed signed cookies from refresh token strategy

* chore: removed signed cookies from refresh RTCookie decorator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants