chore(i18n): update tw translations

[5idereal]

No description provided.

[liyasthomas]

Hi @SiderealArt, thanks for taking the time to help us translate Hoppscotch to your favorite languages.

LTGM.

[lgtm-com]

This pull request introduces 35 alerts and fixes 3 when merging 1837833 into f28b55d - view on LGTM.com

new alerts:

• 35 for Unused variable, import, function or class

fixed alerts:

• 3 for Unused variable, import, function or class

[TonyRL]

Just curious.
Haven't I provided most of the tw translations similar to this PR from prior PR #1948 already?

e.g.,
line 140 Connect to a GraphQL...
line 145 Invite list is empty
line 149 ...
approximately line 265 translations for the whole profile, etc... and so on.

[TonyRL]

It seems @SiderealArt started working from main branch and opened this PR trying to merge into main.

A note should be added to TRANSLATIONS.md @liyasthomas telling contributors

• should checkout i18n branch before working on existing translations
• should not start their work from main branch for existing translations
• i18n will be merged into main weekly or so

Otherwise, it is possible that one day a contributor came, saw untranslated strings in tw.json or other languages on main, didn't checkout i18n, did his/her translation works and initiated a PR to main. Repo maintainers switched base branch, merged and BOOM.
All those unmerged works in-between main and i18n disappeared.

---

Side note for @SiderealArt:
From Owners can add, edit, and delete requests, collections and team members. to 擁有者能夠新增、編輯、和刪除請求、組合、及團隊成員。.
And also from Editors can add, edit, and delete requests. to 編輯者能夠新增、編輯、和刪除請求。

A 、 right before 和 or 及. Really? That's not how 、 works, right? I don't see the Ministry of Education's punctuation manual or pedia from Ministry of Education telling you can do that. Or did I miss something in my education?

Second, it would be better to keep the whole translation consistent. All of the translated strings in both main and i18n's tw.json have translated you to 你. Translating you to 您 introduces inconsistency, which has been fixed in #1944 (See solid bullet point 7)

Apart from that, it would be better to finish off all translations before submitting them. A few strings in team left untranslated (which I did translate in #1948).

Having said that, there are a few nice catches like

hoppscotch/packages/hoppscotch-app/locales/tw.json

Line 34 in 0bcfeb8

"undo": "復原",

hoppscotch/packages/hoppscotch-app/locales/tw.json

Line 316 in 0bcfeb8

"image": "影像",

which I didn't notice (plus possibly outdated dict from OpenCC).

---

Anyways, would it be possible to revert this PR and cherry-pick back either #1948 or bed216b and let @SiderealArt put some good stuff in this PR back?

[liyasthomas]

Thanks for pointing out the mistakes in the translations guide. I've updated the guide with proper information on setting the base branch to i18n. And also updated the tw.json with your translations. Thanks again.

[5idereal]

@TonyRL

A 、 right before 和 or 及. Really? That's not how 、 works, right? I don't see the Ministry of Education's punctuation manual or pedia from Ministry of Education telling you can do that. Or did I miss something in my education?

The last 、should be ，, e.g., 編輯者能夠新增、編輯、和刪除請求。 →編輯者能夠新增、編輯，和刪除請求。. It's my fault.

Second, it would be better to keep the whole translation consistent. All of the translated strings in both main and i18n's tw.json have translated you to 你. Translating you to 您 introduces inconsistency, which has been fixed in #1944 (See solid bullet point 7)

Since my changes were all reverted and I'll need to submit another PR, I think we can take the opportunity to change all the 你 into 您。 What's your opinion?

[TonyRL]

@TonyRL

A 、 right before 和 or 及. Really? That's not how 、 works, right? I don't see the Ministry of Education's punctuation manual or pedia from Ministry of Education telling you can do that. Or did I miss something in my education?

The last 、should be ，, e.g., 編輯者能夠新增、編輯、和刪除請求。 →編輯者能夠新增、編輯，和刪除請求。. It's my fault.

Second, it would be better to keep the whole translation consistent. All of the translated strings in both main and i18n's tw.json have translated you to 你. Translating you to 您 introduces inconsistency, which has been fixed in #1944 (See solid bullet point 7)

Since my changes were all reverted and I'll need to submit another PR, I think we can take the opportunity to change all the 你 into 您。 What's your opinion?

LGTM.
Feel free to checkout https://github.com/TonyRL/hoppscotch/commit/5784be3c1e4db37d0a18518ed2c95221f4403341 as it is my pending follow-up PR.