Fixing EXDATE encoding #11
Conversation
required for supporting iCalendar (at least on OS/X 10.6). We're also now correctly encoding the dates and times as per the iCalendar specification.
| true // $append | ||
| ); | ||
| } else { | ||
|
|
There was a problem hiding this comment.
Why is this necessary? We only support daily recurrences as the finest grained recurrence interval anyway, so DATE fields should be sufficient. And if some whacky client requires this (is this iCal again?) did you make sure that the generated DATE-TIME exception value has the correct timezone?
There was a problem hiding this comment.
Unless I'm misreading the code, timezone id's ignored within Kronolith_Event anyway, and everything gets converted to GMT. Although I consider this a 'bad thing', the underlying data model also does not support timezones per event, so there's little harm there.
The reason I wanted to support the 'DATETIME', is because fromiCalendar function also supports it. When iCal sends me the exception dates (correctly) for non-all-day events, the time-part simply gets cut off and stored anyway. So by adding support for the DATETIME property also in this way, at least both fromiCalendar and toiCalendar work synchronously.
The last part.. The reason I'm creating 1 EXDATE property for every exception, rather than 1 property with all the exceptions comma-separated is indeed because iCalendar has a parsing bug.
There was a problem hiding this comment.
Oh and I just had a second look. Kronolith does in fact correctly support non-all-day recurring events just fine. Maybe you're confused by the fact that Kronolith does not support a higher granularity than per-day recursion, which is correct; but my patch is still needed to support that feature correctly.
10.6 Address Book.app
|
I merged the separate EXDATE attributes but left out the DATE-TIME changes because we don't need them at the moment, and the vCard changes because they would break the current SyncML implementation. |
required for supporting iCalendar (at least on OS/X 10.6). We're also
now correctly encoding the dates and times as per the iCalendar
specification.