Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests]: CI tests to check code works properly #1

Open
3 tasks
Horizon733 opened this issue Sep 30, 2021 · 10 comments · May be fixed by #7
Open
3 tasks

[Tests]: CI tests to check code works properly #1

Horizon733 opened this issue Sep 30, 2021 · 10 comments · May be fixed by #7
Labels
good first issue Good for newcomers hacktoberfest part of hacktoberfest help wanted Extra attention is needed

Comments

@Horizon733
Copy link
Owner

  • tests to verify certificates saved
  • test for extracting names from excel sheet
  • test to vallidate hex color codes
@Horizon733 Horizon733 added good first issue Good for newcomers hacktoberfest part of hacktoberfest help wanted Extra attention is needed labels Sep 30, 2021
@AvineshTripathi
Copy link

AvineshTripathi commented Sep 30, 2021

I was willing to work on this issue can you assign me
also are you planning to use linter and which tool are you using for CI

@Horizon733
Copy link
Owner Author

I was willing to work on this issue can you assign me also are you planning to use linter and which tool are you using for CI

Good to see you want to contribute, so currently this tool repo is new and I will be using CI for workflows. So, you can write tests which work with Circle CI workflow

@AvineshTripathi
Copy link

I ll do it then

@AvineshTripathi
Copy link

AvineshTripathi commented Oct 2, 2021

hey @Horizon733 I m not able to setup the repo in my local can you guide me for the same

@Horizon733
Copy link
Owner Author

hey @Horizon733 I m not able to setup the repo in my local can you guide me for the same

Hi, what's the issue you are facing

@AvineshTripathi
Copy link

M getting 2 error in my builder.py also do we have to make separate png, exel file and ttf file ?

@Horizon733
Copy link
Owner Author

M getting 2 error in my builder.py also do we have to make separate png, exel file and ttf file ?

Yes while generating a certificate, you will need png, excel and ttf file. If you have a look at README there I have mentioned this.
Also, please add everything while asking for a solution for error as follows.
OS:
Python version
error stacktrace
screenshots of errors
And other relevant information

@AvineshTripathi
Copy link

Screenshot from 2021-10-02 11-57-12

(error stacktrack)

Screenshot from 2021-10-02 11-59-39

(builder.py)
Python 3.8.10(python version )

-> also you have not mentioned the point of downloading dependencies from requirements.txt

@Horizon733
Copy link
Owner Author

Horizon733 commented Oct 2, 2021

Screenshot from 2021-10-02 11-57-12

(error stacktrack)

Screenshot from 2021-10-02 11-59-39

(builder.py) Python 3.8.10(python version )

-> also you have not mentioned the point of downloading dependencies from requirements.txt

Thanks for raising this issue, and I have updated the readme and could please open another issue focusing on the first screenshot. It would be helpful for people who want to contribute and link their pr with that issue. Make sure to add all details for error.

@AvineshTripathi
Copy link

issue resolved started working on CI test on circleci

@AvineshTripathi AvineshTripathi linked a pull request Oct 2, 2021 that will close this issue
@AvineshTripathi AvineshTripathi removed their assignment Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest part of hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants