Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map): set default baseLayer to OSM #1600

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

NSUWAL123
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR replaces the current default baselayer(Mapbox) to OSM to solve the map not visible issue.

Screenshots

image

@github-actions github-actions bot added the frontend Related to frontend code label Jun 27, 2024
@spwoodcock
Copy link
Member

@varun2948 can you remember why we used a mapbox layer instead of direct OSM?

Is it so we can add our own content on top at some point?

@spwoodcock
Copy link
Member

This will affect dev stage and prod.

I suggest we:

  • Renew the token a last time if possible (so we don't need a hotfix to prod).
  • Then push this code through to replace using mapbox in the next release.

@spwoodcock spwoodcock merged commit af254a0 into hotosm:development Jun 27, 2024
3 of 4 checks passed
spwoodcock pushed a commit that referenced this pull request Jun 27, 2024
* fix(map): set default baseLayer to OSM

* fix(layerSwitcher): mapbox layers remove
spwoodcock pushed a commit that referenced this pull request Jun 27, 2024
* fix(map): set default baseLayer to OSM

* fix(layerSwitcher): mapbox layers remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants