Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amending image location in Osmand2 section in line with #306 #397

Merged
merged 7 commits into from
May 26, 2015

Conversation

Nick-Tallguy
Copy link
Collaborator

Amending image location in line with #306

This pull request now relates to several files & associated images. I've viewed all locally using jekyll serve & I'm happy that all links will work and only redundant images have been removed.

@Nick-Tallguy
Copy link
Collaborator Author

@althio It's probably best if I just go ahead & merge these commits and the following ones - I'm simplifying the image filing system, removing duplicates and removing the redundant images that I find. Before I submit the pull request on any of them, or do the commit, I run the updated site on my machine using jekyll & check that the image links all work. Sometimes I'm sorting out slight problems as I find them - images in some sections of the beginner section in French are now fixed & I'll fix other problems if I find them.

With the number of changes, at some point I may well make a mistake, but I'm taking care to minimise the risk of this.

Although we normally check each others work, I think it will be nearly impossible for you to check every single change I make to links and duplicates.

Let me know if you would prefer to check my changes, otherwise I will just get on and merge them unless I am making some change that could be controversial.

@althio
Copy link
Collaborator

althio commented May 26, 2015

@Nick-Tallguy

images in some sections of the beginner section in French are now fixed & I'll fix other problems if I find them.

Thanks for that!

With the number of changes, at some point I may well make a mistake, but I'm taking care to minimise the risk of this.
Although we normally check each others work, I think it will be nearly impossible for you to check every single change I make to links and duplicates.
Let me know if you would prefer to check my changes, otherwise I will just get on and merge them unless I am making some change that could be controversial.

By all means, go ahead and merge on your own if you are confident with your experience and local test.

Nick-Tallguy added a commit that referenced this pull request May 26, 2015
amending image location in Osmand2 section in line with #306
@Nick-Tallguy Nick-Tallguy merged commit 09e9de1 into hotosm:gh-pages May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants