Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub typo #535

Closed
wants to merge 3 commits into from
Closed

Fix GitHub typo #535

wants to merge 3 commits into from

Conversation

hugovk
Copy link

@hugovk hugovk commented Sep 12, 2017

No description provided.

@michael63-osm
Copy link
Collaborator

@hugovk Thank you for the time you took to go over all the files to such great detail. Although merging these pull requests (including #536 #537 #538) is easy from a technical point of view I would like to address an issue. Apart from English we currently support 14 other languages on learnosm.org and 5 more on a staging site where we collect things before they are mature enough to be released to the main site.

What we need to make clear here is that we hardly ever change any documents in other languages directly in this repository because most translators will not be familiar with the process of forking repositories and pull requests. We rather use Transifex for translation management. This is explained in the first section of http://learnosm.org/en/contribute/translator/. I am sorry that this did not appear so far on this site.

If we merge your changes to English documents and update the resources on Transifex then all translations for these modified strings will be wiped out. Translators might notice this, have a look, do not understand what is happening. I would not be surprised if they thought that this is due to some technical error and simply pull their previous translation from the history and insert it again.

To my knowledge there is no way to automatically change translated strings on Transifex. I feel reluctant to merge your pull request before I can see a smooth workflow to accomplish this for all languages concerned.

Michael

@hugovk
Copy link
Author

hugovk commented Sep 13, 2017

I understand, feel free to close these :)

@Nick-Tallguy
Copy link
Collaborator

Closing in view of the discussions already taken place - I've noted the spelling mistake and will try not to make it in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants