Configurable comment and chat limits. Fixes #970 #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make comment and chat length limits configurable through `maxCommentLength` and `maxChatLength` settings, respectively, in the taskingmanager.config.json file. * Set default limit to 5000 characters for both comments and chats. * Include migration to remove the 250 character limit from the project_chat.message column.
ethan-nelson
approved these changes
Sep 14, 2018
|
For interested parties, the task comment is already set to not have a maximum length in the database, so that's why it is not needed in the migration file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make comment and chat length limits configurable through
maxCommentLengthandmaxChatLengthsettings, respectively, in the taskingmanager.config.json file.Set default limit to 5000 characters for both comments and chats.
Include migration to remove the 250 character limit from the project_chat.message column.