Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix when Invalidating badimagery tasks #1556

Merged
merged 1 commit into from May 9, 2019
Merged

fix when Invalidating badimagery tasks #1556

merged 1 commit into from May 9, 2019

Conversation

JorgeMartinezG
Copy link
Contributor

This pull request fixes issue #1552. The get_last_mapped_action method from TaskHistory class returned only tasks with MAPPED status, making the error defined in the issue for BADIMAGERY ones.

How to test:

  • Create a project.
  • Map some tasks as bad imagery.
  • When validating mark task as invalid.

invalid

@xamanu xamanu added this to the 3.3 Release milestone May 9, 2019
@xamanu xamanu self-assigned this May 9, 2019
xamanu
xamanu approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@xamanu xamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well. Thanks for the fast fix.

@xamanu xamanu removed their assignment May 9, 2019
@xamanu xamanu merged commit e23139c into hotosm:develop May 9, 2019
@Vaomatua Vaomatua mentioned this pull request May 9, 2019
Closed
@xamanu xamanu mentioned this pull request May 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xamanu xamanu xamanu approved these changes

Assignees
No one assigned
Labels
priority: high scope: backend status: done type: bug
Projects
None yet
Milestone
3.3 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JorgeMartinezG @xamanu