Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed osm download destroy issue #6375

Conversation

varun2948
Copy link
Contributor

@varun2948 varun2948 commented May 1, 2024

What type of PR is this? (check all applicable)

  • πŸ› Bug Fix

Related Issue

Describe this PR

This PR fixes the crash issue on osm download component which was caused due to the react,node upgrade

Screenshots

Issue:
image

After Fix :
image

Review Guide

Notes for the reviewer. How to test this change?

  1. Go into the Single Project Details.
  2. Go Back to the projects lists.
  3. Error Shows up.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot added dependencies Pull requests that update a dependency file codebase: frontend labels May 1, 2024
@varun2948
Copy link
Contributor Author

@ramyaragupathy we currently have issue on CircleCI because of the node version upgrade and need a change on the CIRCLECI config and i just consult with @mahesh-naxa and he suggested to do multiple changes on CircleCI config for upgrading the node version on CircleCI which he would be doing. so might have to wait for him to fix this
Cc: @royallsilwallz @manjitapandey

@mahesh-naxa
Copy link
Contributor

Looks like there are two checks failing.

  1. Build & Push Image: This is strictly a permission issue related to git-hub package repository.
ERROR: denied: installation not allowed to Write organization package
Error: buildx failed with: ERROR: denied: installation not allowed to Write organization package

passing this down to @eternaltyro

  1. frontend-code-test: I think the original PR for dependency update to node 18 didn't have circleci config updated to use the newer node v18 .

will update those in a seperate PR ASAP.

@mahesh-naxa
Copy link
Contributor

cc: @ramyaragupathy @varun2948

@varun2948 varun2948 force-pushed the fix-frontend-dependency-osm-download-issue branch from 1f324ba to 72db554 Compare May 2, 2024 04:50
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@varun2948
Copy link
Contributor Author

@ramyaragupathy @royallsilwallz @manjitapandey everything is passed except the two that DK had already mentioned will be failed anyways so it is good to go i guess.

@ramyaragupathy
Copy link
Member

frontend-code-test: I think the original PR for dependency update to node 18 didn't have circleci config updated to use the newer node v18 .
@mahesh-naxa thanks for capturing the details clearly. Is the circle CI config update directly related to #6405?

@mahesh-naxa
Copy link
Contributor

@ramyaragupathy I have updated circleci with the newer node versions, this one is specific to this PR, as this PR is generated from a fork by @varun2948.

#31 ERROR: denied: installation not allowed to Write organization package

Its an an auth issue where packages are not allowed to be pushed to github container registry from a forked repo.
(also its safe to ignore github actions related workflows for building docker images, as they are still being worked on, and is seperate from CircleCI's jobs.)

@ramyaragupathy ramyaragupathy merged commit 4de0ad8 into hotosm:develop May 3, 2024
6 of 8 checks passed
@ramyaragupathy ramyaragupathy added this to the v4.7.2 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file scope: frontend ui/ux πŸ‘₯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OSM download components crashes due to node version upgrade to 18
5 participants