Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Circle CI and Docker build failing due to unupdated version of node #6397

Merged
merged 2 commits into from
May 1, 2024

Conversation

mahesh-naxa
Copy link
Contributor

@mahesh-naxa mahesh-naxa commented May 1, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Fixes the frontend tests failing issue on #6375 & develop branch.

Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mahesh-naxa
Copy link
Contributor Author

The tests seems to be working with the latest circleci image cimg/node:18.19.1.

However i am not sure why the image cimg/python:3.10.7-node was choosen for the deploy steps, I have replaced those with the cimg/node:18.19.1. If there wasn't a specific need the PR can be safely merged, without breaking the deployment steps.

Just to let you know i did test the install-ability these:

  • libgeos-dev jq aws-cli
  • @mapbox/cfn-config @mapbox/cloudfriend

- image: cimg/python:3.10.7-node

- image: cimg/python:3.10.7-node

(maybe just merging this and testing if the deployment works straight to our develop also could be wise @ramyaragupathy )
cc @eternaltyro @dakotabenjamin

@dakotabenjamin
Copy link
Member

I think the reasoning was frontend uses node and backend uses python. If the node image contains a fixed version of python then it's all good to me IMO.

@dakotabenjamin dakotabenjamin self-requested a review May 1, 2024 13:24
@ramyaragupathy ramyaragupathy merged commit 2a53bcc into develop May 1, 2024
9 of 10 checks passed
@ramyaragupathy ramyaragupathy added this to the v4.7.2 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants