Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add .bundle to .gitignore #677

Merged
merged 1 commit into from Oct 7, 2012

Conversation

Projects
None yet
6 participants
Contributor

lest commented Oct 6, 2012

No description provided.

Contributor

steveklabnik commented Oct 6, 2012

👍

@ghost ghost assigned AriT93 and zph Oct 6, 2012

Contributor

zph commented Oct 6, 2012

Misclicked on android github app :p. But I'll check it when home and merge.

Contributor

steveklabnik commented Oct 6, 2012

Hm. Is this actually necessary? Why don't we have a .bundle directory in the current checkin?

Contributor

zph commented Oct 7, 2012

Leaving this one for someone more familiar the project. 😄

Contributor

lest commented Oct 7, 2012

From the bundler documentation:

Before deploying an app that uses Bundler, Add your Gemfile and Gemfile.lock to source control, but ignore the .bundle folder, which is specific to each machine.

Contributor

steveklabnik commented Oct 7, 2012

Right, I'm not denying that it's a good idea, I'm just curious if it's some sort of default these days. And why, if this hasn't been in our .gitignore, we don't have one in source control already

Contributor

jrgifford commented Oct 7, 2012

I know I have mine in my global gitignore.

Contributor

wilkie commented Oct 7, 2012

Tsk Tsk. Yet another application stuffing things in the project directory instead of somewhere else outside of the repo so that they have to depend on the ignore semantics of your-favorite-source-control. And of course, you cannot depend on anybody have a sane global .gitignore (.hgignore, etc) either.

Freaking bad manner I tells ya!

Now, I believe the default for bundler is currently ~/.bundle and rvm especially sets GEM_HOME so that they are installed in isolation as a gemset. Therefore, we will never see a .bundle directory... and I've never seen one in any project directory. When can this occur such that this would be a problem?

Contributor

lest commented Oct 7, 2012

@wilkie I used to run bundle install --path to install gems from different projects to the different locations. So it creates .bundle/config yaml file with config including gem path.

Contributor

steveklabnik commented Oct 7, 2012

Yet another application stuffing things in the project directory instead of somewhere else outside of the repo so that they have to depend on the ignore semantics of your-favorite-source-control.

This is because it's important for things like, say, deployment.

Anyway, global .gitignore makes sense. Good enough reason for me. Merged. Thanks.

steveklabnik added a commit that referenced this pull request Oct 7, 2012

Merge pull request #677 from lest/patch-1
add .bundle to .gitignore

@steveklabnik steveklabnik merged commit 3185ac7 into hotsh:master Oct 7, 2012

1 check passed

default The Travis build passed
Details

@wilkie wilkie referenced this pull request Oct 11, 2012

Merged

Ignore vendor/bundle folder #681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment