Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add pull_to_refresh_enabled #128

Closed
leonvogt opened this issue Jul 4, 2023 · 3 comments
Closed

[Feature request] Add pull_to_refresh_enabled #128

leonvogt opened this issue Jul 4, 2023 · 3 comments

Comments

@leonvogt
Copy link
Contributor

leonvogt commented Jul 4, 2023

Hi,

I've noticed that the Turbo Android library can receive an option called pull_to_refresh_enabled via the path configuration, which controls whether a view is refreshable.

I think it would be cool to have this feature in Turbo iOS too.

I wanted to check if you're cool with adding this feature to the library. If you like the idea, I'm happy to contribute and submit a pull request.

@joemasilotti
Copy link
Member

I think that in the future we want to support all of those options available from Android! I'm working through presentation and context in my Turbo Navigator project. Which I'm hoping eventually will get merged upstream here.

Digging into this, adding any sort of Path Configuration reading might require a re-architecture of how turbo-ios works. Hence my other project which "wraps" this framework.

So I'm hesitant to merge a one-off PR that only handles one of these options and not all of them. At risk of having to rework the entire thing again in the near future.

But if you have an idea for a clean approach that doesn't change the public API then I'd love to see it! No promises on merging right now but it could kickstart a conversation.

@leonvogt
Copy link
Contributor Author

leonvogt commented Jul 8, 2023

Fair enough. It makes sense not to rush this restructuring.
I'll wait until Turbo Navigator will hopefully get upstreamed 😄

@joemasilotti
Copy link
Member

This is now supported in PR #158 which upstreams Turbo Navigator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants