-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webview fixes #73
Closed
spinosa
wants to merge
3
commits into
hotwired:main
from
TheFixableCorporation:spinosa_webview_fixes
Closed
Webview fixes #73
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Notes | ||
|
||
## UIRefreshControl + viewport-fit=cover bug | ||
|
||
To scale the viewport of a browser to fill the display, you may have set viewport-fit=cover; | ||
`<meta name="viewport" content="viewport-fit=cover">`. | ||
|
||
If a view `allowsPullToRefresh` in a turbo-ios native app with `viewport-fit=cover`, | ||
the UIRefreshControl will not be positioned as expected. | ||
|
||
You can fix this by conditionally removing `viewport-fit=cover` when loading in a native app. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a screenshot for this issue?
We set the viewport to
width=device-width,initial-scale=1,maximum-scale=1,viewport-fit=cover
and haven't noticed this issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be confounders at play. Would need to repro on a minimal app. But here are screenshots of our app (deployment target 14.0, running on 15.4.1) where the only difference is the inclusion of
viewport-fit=cover
:Without
viewport-fit=cover
:With
viewport-fit=cover
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh you're right ours does that too, now I look at it. I was always like 🤷 that's high up but whatever.