Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uninitialized constant Turbo::Broadcastable::TestHelper::ActionCable #573

Closed
jcoyne opened this issue Feb 9, 2024 · 3 comments · Fixed by #574
Closed

uninitialized constant Turbo::Broadcastable::TestHelper::ActionCable #573

jcoyne opened this issue Feb 9, 2024 · 3 comments · Fixed by #574

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Feb 9, 2024 •
edited

When generating a Rails app with --skip-action-cable and then installing turbo rails 2.0.2 I see this error when I load the test environment:

NameError:
  uninitialized constant Turbo::Broadcastable::TestHelper::ActionCable

This was not a problem with turbo-rails 1.5.0 or 2.0.0
@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 9, 2024 •
edited

@swanson could this have been introduced by #565 ? via https://github.com/hotwired/turbo-rails/blob/main/lib/turbo/broadcastable/test_helper.rb#L7

@taylorthurlow
Copy link

Looks like you beat me to this one by 10 minutes. Yeah it's definitely the test helper assuming that ActionCable is available. I believe the entire test helper should be able to be skipped if ActionCable isn't present, the helper isn't useful otherwise.

seanpdoyle added a commit to seanpdoyle/turbo-rails that referenced this issue Feb 9, 2024
@seanpdoyle
Only include Turbo::Broadcastable::TestHelper with Action Cable
c5ba89d 
Closes [hotwired#573][]
Related to [hotwired#565][]

Re-structure the automatic inclusion of the
`Turbo::Broadcastable::TestHelper` module so that it's only
automatically loaded and installed when Action Cable is available to the
runtime.

[hotwired#573]: hotwired#573
[hotwired#565]: hotwired#565 (comment)
@seanpdoyle seanpdoyle mentioned this issue Feb 9, 2024
Merged
@seanpdoyle
Copy link
Contributor

seanpdoyle commented Feb 9, 2024 •
edited

I've opened #574 to try to address this.

I'm a little hazy on the loading order quirks, so could you pull it down and test it out with your application's test harnesses?

jcoyne added a commit to projectblacklight/blacklight that referenced this issue Feb 9, 2024
@jcoyne
Stop skipping action-cable temporarily
b3a56cf 
This works around a bug in turbo-rails 2.0.2 hotwired/turbo-rails#573
We should be able to revert this if that issue is resolved in a future release
@jcoyne jcoyne mentioned this issue Feb 9, 2024
Merged
seanpdoyle added a commit to seanpdoyle/turbo-rails that referenced this issue Feb 9, 2024
@seanpdoyle
Only include Turbo::Broadcastable::TestHelper with Action Cable
8a0499d 
Closes [hotwired#573][]
Related to [hotwired#565][]

Re-structure the automatic inclusion of the
`Turbo::Broadcastable::TestHelper` module so that it's only
automatically loaded and installed when Action Cable is available to the
runtime.

[hotwired#573]: hotwired#573
[hotwired#565]: hotwired#565 (comment)
seanpdoyle added a commit to seanpdoyle/turbo-rails that referenced this issue Feb 9, 2024
@seanpdoyle
Only include Turbo::Broadcastable::TestHelper with Action Cable
f41a90d 
Closes [hotwired#573][]
Related to [hotwired#565][]

Re-structure the automatic inclusion of the
`Turbo::Broadcastable::TestHelper` module so that it's only
automatically loaded and installed when Action Cable is available to the
runtime.

[hotwired#573]: hotwired#573
[hotwired#565]: hotwired#565 (comment)
afcapel pushed a commit that referenced this issue Feb 9, 2024
@seanpdoyle
Only include Turbo::Broadcastable::TestHelper with Action Cable (#574)
07d3488 
Closes [#573][]
Related to [#565][]

Re-structure the automatic inclusion of the
`Turbo::Broadcastable::TestHelper` module so that it's only
automatically loaded and installed when Action Cable is available to the
runtime.

[#573]: #573
[#565]: #565 (comment)
@aaronjensen aaronjensen mentioned this issue Feb 10, 2024
Closed
jcoyne added a commit to projectblacklight/blacklight that referenced this issue Feb 15, 2024
@jcoyne
Stop skipping action-cable temporarily
9eacc45 
This works around a bug in turbo-rails 2.0.2 hotwired/turbo-rails#573
We should be able to revert this if that issue is resolved in a future release
@jcoyne jcoyne mentioned this issue Feb 15, 2024
Merged
jcoyne added a commit to projectblacklight/blacklight that referenced this issue Feb 15, 2024
@jcoyne
Stop skipping action-cable temporarily
d830beb 
This works around a bug in turbo-rails 2.0.2 hotwired/turbo-rails#573
We should be able to revert this if that issue is resolved in a future release
newheaven918 added a commit to newheaven918/turbo that referenced this issue Apr 26, 2024
@newheaven918
Only include Turbo::Broadcastable::TestHelper with Action Cable (#574)
a633a00 
Closes [#573][]
Related to [#565][]

Re-structure the automatic inclusion of the
`Turbo::Broadcastable::TestHelper` module so that it's only
automatically loaded and installed when Action Cable is available to the
runtime.

[#573]: hotwired/turbo-rails#573
[#565]: hotwired/turbo-rails#565 (comment)
luisjose1996 added a commit to luisjose1996/Turbo-Rails that referenced this issue May 10, 2024
@luisjose1996
Only include Turbo::Broadcastable::TestHelper with Action Cable (#574)
7d979dc 
Closes [#573][]
Related to [#565][]

Re-structure the automatic inclusion of the
`Turbo::Broadcastable::TestHelper` module so that it's only
automatically loaded and installed when Action Cable is available to the
runtime.

[#573]: hotwired/turbo-rails#573
[#565]: hotwired/turbo-rails#565 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only include Turbo::Broadcastable::TestHelper with Action Cable seanpdoyle/turbo-rails
3 participants
@jcoyne @taylorthurlow @seanpdoyle