Make activejob optional #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjensen
force-pushed
the
optional-active-job
branch
from
2ff1abf
to
20ac7d8
Compare
|
@afcapel Is this something you would be able to merge? It'd nice to get this one in. Thank you. |
aaronjensen
force-pushed
the
optional-active-job
branch
from
20ac7d8
to
9fdd3e0
Compare
|
@seanpdoyle along the same lines as #573 and #574 if you would merge this to support not requiring ActiveJob, I'd appreciate it. Thank you. |
|
Replaced by #602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478
There was already precedent for optional Rails dependencies (action cable), so I followed that.
We could consider combining the two initializers at this point, but I'm not sure what we'd name it.