Navigate a lazy-loaded turbo-frame #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
frame-loading-lazy-anchor
branch
from
90a806d
to
0e51f42
Compare
|
Intuitively I'd expect setting src on a lazy frame to take effect as soon as the element intersects the viewport, but a quick test shows that <img loading=lazy> seems to behave the way you describe above. So, let's roll with it. Could you rebase this against main? |
Problem --- Consider a `<turbo-frame>` element with `loading="lazy"`. Once it becomes visible, the `AppearanceObserver` will delegate to the `FrameController` to load its contents. However, once visible, subsequent navigations of that frame will continue to be deferred, since its `[loading]` attribute is still deferred, in spite of the fact that the element is visible on that page. Proposed change --- This commit proposes to immediately navigate a `<turbo-frame>` element with `[loading="eager"]` _or_ a `<turbo-frame>` element that has been loaded previously. Possible alternatives --- As an alternative to adding another conditional to the guard clause, could it be worthwhile to treat navigational changes driven by `<a>` clicks or `<form>` submissions different from programatically modifying the element's `[src]` attribute? Do Custom Elements support changing an attribute's value without also kicking off change callbacks?
seanpdoyle
force-pushed
the
frame-loading-lazy-anchor
branch
from
0e51f42
to
543b528
Compare
|
@sstephenson I've rebased and updated this branch. |
|
Thank you! |
en30
added a commit
to en30/turbo
that referenced
this pull request
Jul 24, 2021
`<turbo-frame>`'s loading behaviour was disscued in hotwired#212 . This commit try to represent the intent as code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Consider a
<turbo-frame>element withloading="lazy". Once itbecomes visible, the
AppearanceObserverwill delegate to theFrameControllerto load its contents.However, once visible, subsequent navigations of that frame will
continue to be deferred, since its
[loading]attribute is stilldeferred, in spite of the fact that the element is visible on that page.
Proposed change
This commit proposes to immediately navigate a
<turbo-frame>elementwith
[loading="eager"]or a<turbo-frame>element that has beenloaded previously.
Possible alternatives
As an alternative to adding another conditional to the guard clause,
could it be worthwhile to treat navigational changes driven by
<a>clicks or
<form>submissions different from programatically modifyingthe element's
[src]attribute? Do Custom Elements support changing anattribute's value without also kicking off change callbacks?