Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support development ChromeDriver version overrides #606

Merged
merged 1 commit into from
Jun 22, 2022

Commits on Jun 20, 2022

  1. Support development ChromeDriver version overrides

    Refines the changes introduced to the CI configuration made in
    [b1cbe12][].
    
    Recent Chrome upgrades are causing errors like the following while
    executing the test suite locally:
    
    ```
    SessionNotCreatedException: [POST http://localhost:4444/wd/hub/session / {"desiredCapabilities":{"name":"intern","idle-timeout":60,"browserName":"chrome","goog:chromeOptions":{"args":["headless","disable-gpu","no-sandbox"]},"browser":"chrome"}}] session not created: This version of ChromeDriver only supports Chrome version 99
    Current browser version is 102.0.5005.115 with binary path
    ```
    
    The **only supports Chrome version 99** portion is due to `digdug`'s
    locked-support for Chrome version 99 declared in its [webdrivers.json][]
    file.
    
    This commit checks for the presence of the `CHROMEVER` environment
    variable, and overrides the [intern.json](./intern.json) configuration
    to incorporate that into its `tunnelOptions.drivers` value.
    
    [webdrivers.json]: https://github.com/theintern/digdug/blob/806dcf29c2265d3cb1a26a09ef5b43e93fc2a739/src/webdrivers.json#L8-L11
    [b1cbe12]: hotwired@b1cbe12
    seanpdoyle committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    14656db View commit details
    Browse the repository at this point in the history