Support development ChromeDriver version overrides #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
commented
Jun 20, 2022
.github/workflows/ci.yml
Outdated
| @@ -22,12 +22,8 @@ jobs: | |||
|
|
|||
| - name: Set Chrome Version | |||
| run: | | |||
| CHROMEVER="$(chromedriver --version | cut -d' ' -f2)" | |||
| export CHROMEVER="$(chromedriver --version | cut -d' ' -f2)" | |||
There was a problem hiding this comment.
@keithamus and @koddsson this incorporates the CI configuration you two introduced in b1cbe12 to support development-environment configurations.
It's still an incomplete developer experience and requires an awareness of your local chrome driver version.
On top of that, I'm not sure how to programmatically set a GitHub actions environment variable in this way, export doesn't seem to cut it.
There was a problem hiding this comment.
On top of that, I'm not sure how to programmatically set a GitHub actions environment variable in this way, export doesn't seem to cut it.
Evidently, piping an assignment into $GITHUB_ENV does the trick!
seanpdoyle
force-pushed
the
intern-chromedriver-version
branch
2 times, most recently
from
c9cef27
to
b83c04d
Compare
Refines the changes introduced to the CI configuration made in [b1cbe12][]. Recent Chrome upgrades are causing errors like the following while executing the test suite locally: ``` SessionNotCreatedException: [POST http://localhost:4444/wd/hub/session / {"desiredCapabilities":{"name":"intern","idle-timeout":60,"browserName":"chrome","goog:chromeOptions":{"args":["headless","disable-gpu","no-sandbox"]},"browser":"chrome"}}] session not created: This version of ChromeDriver only supports Chrome version 99 Current browser version is 102.0.5005.115 with binary path ``` The **only supports Chrome version 99** portion is due to `digdug`'s locked-support for Chrome version 99 declared in its [webdrivers.json][] file. This commit checks for the presence of the `CHROMEVER` environment variable, and overrides the [intern.json](./intern.json) configuration to incorporate that into its `tunnelOptions.drivers` value. [webdrivers.json]: https://github.com/theintern/digdug/blob/806dcf29c2265d3cb1a26a09ef5b43e93fc2a739/src/webdrivers.json#L8-L11 [b1cbe12]: hotwired@b1cbe12
seanpdoyle
force-pushed
the
intern-chromedriver-version
branch
from
b83c04d
to
14656db
Compare
|
Is this ready to go or it needs feedback from @keithamus and @koddsson? |
dhh
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Jul 15, 2022
* main: Drive Browser tests with `playwright` (hotwired#609) Allow Turbo Streams w/ GET via `data-turbo-stream` (hotwired#612) Only update history when Turbo visit is renderable (hotwired#601) Support development ChromeDriver version overrides (hotwired#606) Turbo stream source (hotwired#415) Expose Frame load state via `[complete]` attribute (hotwired#487)
dhh
added a commit
to feliperaul/turbo
that referenced
this pull request
Jul 16, 2022
* main: Allow frames to scroll smoothly into view (hotwired#607) Export Type declarations for `turbo:` events (hotwired#452) Add .php as a valid isHTML extension (hotwired#629) Add original click event to 'turbo:click' details (hotwired#611) Drive Browser tests with `playwright` (hotwired#609) Allow Turbo Streams w/ GET via `data-turbo-stream` (hotwired#612) Only update history when Turbo visit is renderable (hotwired#601) Support development ChromeDriver version overrides (hotwired#606) Turbo stream source (hotwired#415) Expose Frame load state via `[complete]` attribute (hotwired#487) fix(ie/edge): form.method='delete', raises Invalid argument. (hotwired#586) Do not declare global types/constants (hotwired#524) Defensively create custom turbo elements (hotwired#483) Use `replaceChildren` in StreamActions.update (hotwired#534)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refines the changes introduced to the CI configuration made in
b1cbe12.
Recent Chrome upgrades are causing errors like the following while
executing the test suite locally:
The only supports Chrome version 99 portion is due to
digdug'slocked-support for Chrome version 99 declared in its webdrivers.json
file.
This commit checks for the presence of the
CHROMEWEBDRIVERenvironmentvariable, and overrides the intern.json configuration
to incorporate that into its
tunnelOptions.driversvalue.