Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate [data-turbo-cache=false] in favor of [data-turbo-temporary] #871

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Deprecate [data-turbo-cache=false] in favor of [data-turbo-temporary] #871

merged 1 commit into from
Feb 15, 2023

Conversation

packagethief
Copy link
Contributor

Renames the [data-turbo-cache=false] attribute (used to denote temporary elements that should be removed before caching) to [data-turbo-temporary] for better similarity with [data-turbo-permanent], its conceptual opposite.

This is a superficial change, but worth it in terms of cohesion, I think. The pairing of "temporary" with "permanent" is just too good to ignore. Also, given the existence of turbo-cache-* as the namespace for page-level cache control, a unique name is less likely to confuse.

References:

@packagethief
Deprecate [data-turbo-cache=false] in favor of [data-turbo-temporary]
c978f79 
Renames the `[data-turbo-cache=false]` attribute (used to denote temporary
elements that should be removed before caching) to `[data-turbo-temporary]` for
better similarity with `[data-turbo-permanent]`, its conceptual opposite.

This is a superficial change, but worth it in terms of cohesion, I think. The
pairing of "temporary" with "permanent" is just too good to ignore. Also, given
the existence of `turbo-cache-*` as the namespace for page-level cache control,
a unique name is less likely to confuse.

References:
- #238
@dhh
Copy link
Member

dhh commented Feb 14, 2023

Love it!

@dhh dhh merged commit e013072 into main Feb 15, 2023
@dhh dhh deleted the jh/turbo-temporary branch February 15, 2023 07:03
packagethief added a commit to hotwired/turbo-site that referenced this pull request Feb 15, 2023
@packagethief
Document [data-turbo-temporary] as the replacement of [data-turbo-cac…
476eca4 
…he=false]

References:
- hotwired/turbo#871
@packagethief packagethief mentioned this pull request Feb 15, 2023
Merged
@packagethief
Copy link
Contributor Author

Thanks! I updated the documentation in hotwired/turbo-site#130

@dhh dhh restored the jh/turbo-temporary branch February 15, 2023 15:40
@dhh dhh deleted the jh/turbo-temporary branch February 15, 2023 15:40
another-rex pushed a commit to google/osv.dev that referenced this pull request Mar 6, 2023
@renovate-bot
Update appengine-frontend (#1032)
b68b442 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@hotwired/turbo](https://turbo.hotwired.dev)
([source](https://togithub.com/hotwired/turbo)) | [`7.2.5` ->
`7.3.0`](https://renovatebot.com/diffs/npm/@hotwired%2fturbo/7.2.5/7.3.0)
|
[![age](https://badges.renovateapi.com/packages/npm/@hotwired%2fturbo/7.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@hotwired%2fturbo/7.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@hotwired%2fturbo/7.3.0/compatibility-slim/7.2.5)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@hotwired%2fturbo/7.3.0/confidence-slim/7.2.5)](https://docs.renovatebot.com/merge-confidence/)
|
| [sass](https://togithub.com/sass/dart-sass) | [`1.58.0` ->
`1.58.3`](https://renovatebot.com/diffs/npm/sass/1.58.0/1.58.3) |
[![age](https://badges.renovateapi.com/packages/npm/sass/1.58.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/sass/1.58.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/sass/1.58.3/compatibility-slim/1.58.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/sass/1.58.3/confidence-slim/1.58.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>hotwired/turbo</summary>

### [`v7.3.0`](https://togithub.com/hotwired/turbo/releases/tag/v7.3.0)

[Compare
Source](https://togithub.com/hotwired/turbo/compare/v7.2.5...v7.3.0)

#### What's Changed

- Don't break out of frames when frame missing by
[@&#8203;kevinmcconnell](https://togithub.com/kevinmcconnell) in
[hotwired/turbo#863
- Respect `turbo-visit-control` for frame requests by
[@&#8203;kevinmcconnell](https://togithub.com/kevinmcconnell) in
[hotwired/turbo#867
- Allow changing the submitter text during form submission by
[@&#8203;afcapel](https://togithub.com/afcapel) in
[hotwired/turbo#869
- Form submissions from frames should clear cache by
[@&#8203;kevinmcconnell](https://togithub.com/kevinmcconnell) in
[hotwired/turbo#882
- Deprecate `[data-turbo-cache=false]` in favor of
`[data-turbo-temporary]` by
[@&#8203;packagethief](https://togithub.com/packagethief) in
[hotwired/turbo#871
- `resume()` does not require `value` by
[@&#8203;dahlbyk](https://togithub.com/dahlbyk) in
[hotwired/turbo#854
- Rename `isIdempotent` to `isSafe` by
[@&#8203;kevinmcconnell](https://togithub.com/kevinmcconnell) in
[hotwired/turbo#883

**Full Changelog**:
hotwired/turbo@v7.2.5...v7.3.0

</details>

<details>
<summary>sass/dart-sass</summary>

###
[`v1.58.3`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#&#8203;1583)

[Compare
Source](https://togithub.com/sass/dart-sass/compare/1.58.2...1.58.3)

-   No user-visible changes.

###
[`v1.58.2`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#&#8203;1582)

[Compare
Source](https://togithub.com/sass/dart-sass/compare/1.58.1...1.58.2)

##### Command Line Interface

-   Add a timestamp to messages printed in `--watch` mode.

- Print better `calc()`-based suggestions for `/`-as-division expression
that
    contain calculation-incompatible constructs like unary minus.

###
[`v1.58.1`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#&#8203;1581)

[Compare
Source](https://togithub.com/sass/dart-sass/compare/1.58.0...1.58.1)

- Emit a unitless hue when serializing `hsl()` colors. The `deg` unit is
    incompatible with IE, and while that officially falls outside our
compatibility policy, it's better to lean towards greater compatibility.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone
Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/google/osv.dev).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE0Ni4yIn0=-->
@eduardoyutaka eduardoyutaka mentioned this pull request Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpdoyle seanpdoyle seanpdoyle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@packagethief @dhh @seanpdoyle